Only run merge-scheduler workflow if it's not a fork

[julieg18]

• As shown by start: use tabs for a Windows command #3215, the merge-schedule workflow only runs for prs that aren't from forks and will fail if it runs on a forked pr.

[julieg18]

Checks if the repo name of the pull request equals the github repo. I tested it with a fork (#3270) and it appears to work correctly!

[rogermparent]

Looks good! Thanks for the quick fix!

[shcheklein]

Is it expected? Is it bc we were experimenting with the GH workflow? Ot does it create a new check / status every hour?

Also, how does the merge work - who is the author of the merge?

Also, do we know why fork didn't work?

[julieg18]

Is it expected? Is it bc we were experimenting with the GH workflow? Ot does it create a new check / status every hour?

@shcheklein Yes, the multiple checks are expected. The check runs every time a pr is opened, edited, or receives new commits.

Also, how does the merge work - who is the author of the merge?

The action uses the github rest api to merge the pr. So I believe the action itself is the author! It should look something like this:

Also, do we know why fork didn't work?

Yes. The github action doesn't run on forks for security reasons.

[shcheklein]

@julieg18 thanks!

@shcheklein Yes, the multiple checks are expected. The check runs every time a pr is opened, edited, or receives new commits.

🤔 hmm, why don't we see the same for the link checker, unit tests, etc? (it's the first time I see the checks being duplicated this way).

anyways, we can't keep it this way I think - it'll be exploding on some long-running PRs

The action uses the github rest api to merge the pr. So I believe the action itself is the author! It should look something like this:

does it mean that anyone can come and create a PR and it'll be automatically merged (if they put a time to merge it in the description)?

Yes. The github action doesn't run on forks for security reasons.

what error message do we see in this case? can it be changed - per repo or per specific action? and the most important - do we want this to be changed (somewhat related to the previous question I think)

[julieg18]

🤔 hmm, why don't we see the same for the link checker, unit tests, etc? (it's the first time I see the checks being duplicated this way).

The same check can be duplicated when it is configured to run for different events. For example, our link-check-deploy runs for two different events and appears twice on a commit:

But most of our checks only need to run for one event and thus, aren't getting duplicated like merge-scheduler

anyways, we can't keep it this way I think - it'll be exploding on some long-running PRs

Agreed! Maybe we can look for github action alternatives or update the configuration for this one.

does it mean that anyone can come and create a PR and it'll be automatically merged (if they put a time to merge it in the description)?

I believe that it can't be merged unless it has atleast one approving review. But I'll create a test right now to be sure.

what error message do we see in this case? can it be changed - per repo or per specific action? and the most important - do we want this to be changed (somewhat related to the previous question I think)

Here's the error message:

I don't think it can be changed. What do you mean exactly by "do we want this to be changed"? Changed to what exactly?

[shcheklein]

Sorry for the confusion. can it be changed == can we change the behavior, the way it behaves on forks.

[julieg18]

Sorry for the confusion. can it be changed == can we change the behavior, the way it behaves on forks.

Oh, ok! Thanks for the clarification! No, I don't think so. The merge-schedule action doesn't offer a way to change this behavior.