Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exercise advert types #1641

Closed
4 tasks done
warrensearle opened this issue Jun 7, 2022 · 1 comment
Closed
4 tasks done

Exercise advert types #1641

warrensearle opened this issue Jun 7, 2022 · 1 comment
Assignees
@lloback
Labels
Passed UT

Comments

@warrensearle
Copy link
Member

warrensearle commented Jun 7, 2022 •
edited by lloback
Loading

Enable exercise teams to better control which information is displayed in the vacancy list & details page.

See this google doc for details.

To do

  • Admin. Enable exercise team to select (and change) the advert type for their exercise
  • Platform. Ensure advert type is included in the Vacancy model
  • Apply. Vacancy listing and details page should support advert types
  • Admin. Ensure an exercise can only be approved with a 'Full' or 'External' advert type

Data Model: exercise.advertType possible values

  • listing
  • basic
  • full (default)
  • external
@lloback lloback mentioned this issue Jun 10, 2022
Merged
2 tasks
@lloback lloback linked a pull request Jun 28, 2022 that will close this issue
#1641 Enable exercise team to select (and change) the advert type #1645
Merged
2 tasks
@lloback lloback removed a link to a pull request Jun 28, 2022
#1641 Enable exercise team to select (and change) the advert type #1645
Merged
2 tasks
@lloback
Copy link
Contributor

lloback commented Jun 28, 2022 •
edited
Loading

Video with the demo

https://drive.google.com/file/d/1fZBTI14NfUNg_FTcjhCcdWutR_9L3_9M/view?usp=sharing

Link to test the functionality

admin: https://jac-admin-develop--1641-lee-5zh4c1az.web.app [expires 2022-07-28 22:02:51]
apply: https://jac-apply-develop--1641-lee-glbw4d53.web.app [expires 2022-07-28 22:05:20]

Pull Requests

@lloback lloback mentioned this issue Jun 28, 2022
Merged
@warrensearle warrensearle removed the Epic label Jun 29, 2022
lloback added a commit that referenced this issue Jun 30, 2022
@lloback
#1641 Enable exercise team to select (and change) the advert type (#1645
fa59ab0 
)

* Enable exercise team to select the advert type

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
HalcyonJAC added a commit that referenced this issue Jul 8, 2022
@HalcyonJAC @dependabot
@tomlovesgithub @lloback @warrensearle
#1620 - character issues google doc report (#1624)
8f34847 
* Character Issues - Added an Export to Google Doc button (that doesn't currently do anything)

* Character Issues - renamed export to gogole doc button

* character issues - export to google doc button now working

* Bump protobufjs from 6.11.2 to 6.11.3 (#1640)

Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eventsource from 1.1.0 to 1.1.1 (#1639)

Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/EventSource/eventsource/releases)
- [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md)
- [Commits](EventSource/eventsource@v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: eventsource
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Share Data answer in equality & diversity questions (#1634)

* share data answer

* share data answer

* Bump version number to 0.88.0

* Lisias permissions (#1646)

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Bump version number to 0.89.0

* Allow/remove access for users (#1644)

* remove addresses

* add address

* amend appCheck logic (#1654)

* membership display and edit (#1633)

* membership display and edit

* redundancy for memberships being empty

* redundancy for memberships being empty

* fix-specific-memberships

* removed commented code

* #1641 Enable exercise team to select (and change) the advert type (#1645)

* Enable exercise team to select the advert type

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Upgrade to use node 16 (#1652)

* Update package, lint and jest config

* Upgrade packages to use node 16

* Update workflows to use node 16

* Updated package-lock

* upgrade to node v16.15.1

* Update workflows to use 16.15.1

* Roll back package lock

* Remove resolutions, for now

* Fix conflicts

* Update package lock

* Fix resolutions

* Final tweaks

* Remove resolutions again

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Bump version number to 0.89.0

* Fix table for node16 (#1674)

* do not merge this

* update-jac-kit

* update-jac-kit

* remove visual flag

* update jac-kit

* Test workflow

* Add confirmation before sending independent assessments request (#1648)

* Revert "Merge branch 'main' into 1620-character-issues-google-doc-report"

This reverts commit f6f14dd, reversing
changes made to 2a38c4b.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
Co-authored-by: warrensearle <warren@precise-minds.co.uk>
HalcyonJAC added a commit that referenced this issue Jul 8, 2022
@HalcyonJAC @dependabot
@tomlovesgithub @lloback @warrensearle
#1621 character issues - reason for recommendation (#1623)
2d1cb36 
* Character Issues - Added a reason for recommendation field

* Character Issues - status is now application-specific

* no message

* use node 12

* Revert "use node 12"

This reverts commit ab6db30.

* #1620 - character issues google doc report (#1624)

* Character Issues - Added an Export to Google Doc button (that doesn't currently do anything)

* Character Issues - renamed export to gogole doc button

* character issues - export to google doc button now working

* Bump protobufjs from 6.11.2 to 6.11.3 (#1640)

Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eventsource from 1.1.0 to 1.1.1 (#1639)

Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/EventSource/eventsource/releases)
- [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md)
- [Commits](EventSource/eventsource@v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: eventsource
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Share Data answer in equality & diversity questions (#1634)

* share data answer

* share data answer

* Bump version number to 0.88.0

* Lisias permissions (#1646)

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Bump version number to 0.89.0

* Allow/remove access for users (#1644)

* remove addresses

* add address

* amend appCheck logic (#1654)

* membership display and edit (#1633)

* membership display and edit

* redundancy for memberships being empty

* redundancy for memberships being empty

* fix-specific-memberships

* removed commented code

* #1641 Enable exercise team to select (and change) the advert type (#1645)

* Enable exercise team to select the advert type

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Upgrade to use node 16 (#1652)

* Update package, lint and jest config

* Upgrade packages to use node 16

* Update workflows to use node 16

* Updated package-lock

* upgrade to node v16.15.1

* Update workflows to use 16.15.1

* Roll back package lock

* Remove resolutions, for now

* Fix conflicts

* Update package lock

* Fix resolutions

* Final tweaks

* Remove resolutions again

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Bump version number to 0.89.0

* Fix table for node16 (#1674)

* do not merge this

* update-jac-kit

* update-jac-kit

* remove visual flag

* update jac-kit

* Test workflow

* Add confirmation before sending independent assessments request (#1648)

* Revert "Merge branch 'main' into 1620-character-issues-google-doc-report"

This reverts commit f6f14dd, reversing
changes made to 2a38c4b.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
Co-authored-by: warrensearle <warren@precise-minds.co.uk>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
Co-authored-by: warrensearle <warren@precise-minds.co.uk>
HalcyonJAC added a commit that referenced this issue Jul 8, 2022
@HalcyonJAC @dependabot
@tomlovesgithub @lloback @warrensearle
#1616 character report statuses (#1618)
636caf2 
* Character Issues - save actions

* tidy-up

* Candidate issues - added issue action filter

* added an unassigned filter

* renamed action to status

* make sure 2nd dropdown is in the same line as the 1st

* filtered not matching results

* fixed unassigned result

* Character Issues - status (and reason) now application-specific

* no message

* typo

* no message

* character issues - fixed filter

* #1621 character issues - reason for recommendation (#1623)

* Character Issues - Added a reason for recommendation field

* Character Issues - status is now application-specific

* no message

* use node 12

* Revert "use node 12"

This reverts commit ab6db30.

* #1620 - character issues google doc report (#1624)

* Character Issues - Added an Export to Google Doc button (that doesn't currently do anything)

* Character Issues - renamed export to gogole doc button

* character issues - export to google doc button now working

* Bump protobufjs from 6.11.2 to 6.11.3 (#1640)

Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3.
- [Release notes](https://github.com/protobufjs/protobuf.js/releases)
- [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md)
- [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3)

---
updated-dependencies:
- dependency-name: protobufjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump eventsource from 1.1.0 to 1.1.1 (#1639)

Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/EventSource/eventsource/releases)
- [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md)
- [Commits](EventSource/eventsource@v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: eventsource
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Share Data answer in equality & diversity questions (#1634)

* share data answer

* share data answer

* Bump version number to 0.88.0

* Lisias permissions (#1646)

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Bump version number to 0.89.0

* Allow/remove access for users (#1644)

* remove addresses

* add address

* amend appCheck logic (#1654)

* membership display and edit (#1633)

* membership display and edit

* redundancy for memberships being empty

* redundancy for memberships being empty

* fix-specific-memberships

* removed commented code

* #1641 Enable exercise team to select (and change) the advert type (#1645)

* Enable exercise team to select the advert type

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Upgrade to use node 16 (#1652)

* Update package, lint and jest config

* Upgrade packages to use node 16

* Update workflows to use node 16

* Updated package-lock

* upgrade to node v16.15.1

* Update workflows to use 16.15.1

* Roll back package lock

* Remove resolutions, for now

* Fix conflicts

* Update package lock

* Fix resolutions

* Final tweaks

* Remove resolutions again

Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>

* Bump version number to 0.89.0

* Fix table for node16 (#1674)

* do not merge this

* update-jac-kit

* update-jac-kit

* remove visual flag

* update jac-kit

* Test workflow

* Add confirmation before sending independent assessments request (#1648)

* Revert "Merge branch 'main' into 1620-character-issues-google-doc-report"

This reverts commit f6f14dd, reversing
changes made to 2a38c4b.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
Co-authored-by: warrensearle <warren@precise-minds.co.uk>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
Co-authored-by: warrensearle <warren@precise-minds.co.uk>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com>
Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk>
Co-authored-by: warrensearle <warren@precise-minds.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lloback lloback

Labels
Passed UT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@warrensearle @lloback @andrew-isaac