membership display and edit #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
approved these changes
May 30, 2022
andrew-isaac
approved these changes
Jun 1, 2022
HalcyonJAC
approved these changes
Jun 14, 2022
HalcyonJAC
added a commit
that referenced
this pull request
Jul 8, 2022
* Character Issues - Added an Export to Google Doc button (that doesn't currently do anything) * Character Issues - renamed export to gogole doc button * character issues - export to google doc button now working * Bump protobufjs from 6.11.2 to 6.11.3 (#1640) Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eventsource from 1.1.0 to 1.1.1 (#1639) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Share Data answer in equality & diversity questions (#1634) * share data answer * share data answer * Bump version number to 0.88.0 * Lisias permissions (#1646) Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Allow/remove access for users (#1644) * remove addresses * add address * amend appCheck logic (#1654) * membership display and edit (#1633) * membership display and edit * redundancy for memberships being empty * redundancy for memberships being empty * fix-specific-memberships * removed commented code * #1641 Enable exercise team to select (and change) the advert type (#1645) * Enable exercise team to select the advert type Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Upgrade to use node 16 (#1652) * Update package, lint and jest config * Upgrade packages to use node 16 * Update workflows to use node 16 * Updated package-lock * upgrade to node v16.15.1 * Update workflows to use 16.15.1 * Roll back package lock * Remove resolutions, for now * Fix conflicts * Update package lock * Fix resolutions * Final tweaks * Remove resolutions again Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Fix table for node16 (#1674) * do not merge this * update-jac-kit * update-jac-kit * remove visual flag * update jac-kit * Test workflow * Add confirmation before sending independent assessments request (#1648) * Revert "Merge branch 'main' into 1620-character-issues-google-doc-report" This reverts commit f6f14dd, reversing changes made to 2a38c4b. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk>
HalcyonJAC
added a commit
that referenced
this pull request
Jul 8, 2022
* Character Issues - Added a reason for recommendation field * Character Issues - status is now application-specific * no message * use node 12 * Revert "use node 12" This reverts commit ab6db30. * #1620 - character issues google doc report (#1624) * Character Issues - Added an Export to Google Doc button (that doesn't currently do anything) * Character Issues - renamed export to gogole doc button * character issues - export to google doc button now working * Bump protobufjs from 6.11.2 to 6.11.3 (#1640) Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eventsource from 1.1.0 to 1.1.1 (#1639) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Share Data answer in equality & diversity questions (#1634) * share data answer * share data answer * Bump version number to 0.88.0 * Lisias permissions (#1646) Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Allow/remove access for users (#1644) * remove addresses * add address * amend appCheck logic (#1654) * membership display and edit (#1633) * membership display and edit * redundancy for memberships being empty * redundancy for memberships being empty * fix-specific-memberships * removed commented code * #1641 Enable exercise team to select (and change) the advert type (#1645) * Enable exercise team to select the advert type Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Upgrade to use node 16 (#1652) * Update package, lint and jest config * Upgrade packages to use node 16 * Update workflows to use node 16 * Updated package-lock * upgrade to node v16.15.1 * Update workflows to use 16.15.1 * Roll back package lock * Remove resolutions, for now * Fix conflicts * Update package lock * Fix resolutions * Final tweaks * Remove resolutions again Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Fix table for node16 (#1674) * do not merge this * update-jac-kit * update-jac-kit * remove visual flag * update jac-kit * Test workflow * Add confirmation before sending independent assessments request (#1648) * Revert "Merge branch 'main' into 1620-character-issues-google-doc-report" This reverts commit f6f14dd, reversing changes made to 2a38c4b. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk>
HalcyonJAC
added a commit
that referenced
this pull request
Jul 8, 2022
* Character Issues - save actions * tidy-up * Candidate issues - added issue action filter * added an unassigned filter * renamed action to status * make sure 2nd dropdown is in the same line as the 1st * filtered not matching results * fixed unassigned result * Character Issues - status (and reason) now application-specific * no message * typo * no message * character issues - fixed filter * #1621 character issues - reason for recommendation (#1623) * Character Issues - Added a reason for recommendation field * Character Issues - status is now application-specific * no message * use node 12 * Revert "use node 12" This reverts commit ab6db30. * #1620 - character issues google doc report (#1624) * Character Issues - Added an Export to Google Doc button (that doesn't currently do anything) * Character Issues - renamed export to gogole doc button * character issues - export to google doc button now working * Bump protobufjs from 6.11.2 to 6.11.3 (#1640) Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eventsource from 1.1.0 to 1.1.1 (#1639) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Share Data answer in equality & diversity questions (#1634) * share data answer * share data answer * Bump version number to 0.88.0 * Lisias permissions (#1646) Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Allow/remove access for users (#1644) * remove addresses * add address * amend appCheck logic (#1654) * membership display and edit (#1633) * membership display and edit * redundancy for memberships being empty * redundancy for memberships being empty * fix-specific-memberships * removed commented code * #1641 Enable exercise team to select (and change) the advert type (#1645) * Enable exercise team to select the advert type Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Upgrade to use node 16 (#1652) * Update package, lint and jest config * Upgrade packages to use node 16 * Update workflows to use node 16 * Updated package-lock * upgrade to node v16.15.1 * Update workflows to use 16.15.1 * Roll back package lock * Remove resolutions, for now * Fix conflicts * Update package lock * Fix resolutions * Final tweaks * Remove resolutions again Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Fix table for node16 (#1674) * do not merge this * update-jac-kit * update-jac-kit * remove visual flag * update jac-kit * Test workflow * Add confirmation before sending independent assessments request (#1648) * Revert "Merge branch 'main' into 1620-character-issues-google-doc-report" This reverts commit f6f14dd, reversing changes made to 2a38c4b. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
An issue was raised regarding General Medical Council membership not showing correctly.
After a review of the
QualificationsAndMembership.vuecode, it appears i had missed the display and edit of certain memberships, GMC being one.This PR should fix to include these memberships and allow their editing by admins as per application edits.
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
Risk - how likely is this to impact other areas?
🟠 Medium risk
Additional context
See above link to slack.
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING