-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1641 Enable exercise team to select (and change) the advert type #1645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lloback, I just tested and found something. When Advert type
is listing
, I can click Submit for approval
but can't approve the exercise. Then I change Advert type
to basic
,
it seems that the exercise is approved and I can click all the buttons (e.g., Unlock, Copy to Clipboard). I wonder that is it supposed to be this way?
Screen.Recording.2022-06-14.at.11.35.50.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lloback - Do you have a preview URL - I checked on Develop and can't see an advert type to test?
I don't have. I will let you know |
@HalcyonJAC this issue was resolved. Please check the EPIC with the video showing the resolution on #1641 |
@andrew-isaac, The PReview URL for this PR is on the EPIC: #1641 |
3fb3ea4
to
ff2f1b6
Compare
* Character Issues - Added an Export to Google Doc button (that doesn't currently do anything) * Character Issues - renamed export to gogole doc button * character issues - export to google doc button now working * Bump protobufjs from 6.11.2 to 6.11.3 (#1640) Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eventsource from 1.1.0 to 1.1.1 (#1639) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Share Data answer in equality & diversity questions (#1634) * share data answer * share data answer * Bump version number to 0.88.0 * Lisias permissions (#1646) Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Allow/remove access for users (#1644) * remove addresses * add address * amend appCheck logic (#1654) * membership display and edit (#1633) * membership display and edit * redundancy for memberships being empty * redundancy for memberships being empty * fix-specific-memberships * removed commented code * #1641 Enable exercise team to select (and change) the advert type (#1645) * Enable exercise team to select the advert type Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Upgrade to use node 16 (#1652) * Update package, lint and jest config * Upgrade packages to use node 16 * Update workflows to use node 16 * Updated package-lock * upgrade to node v16.15.1 * Update workflows to use 16.15.1 * Roll back package lock * Remove resolutions, for now * Fix conflicts * Update package lock * Fix resolutions * Final tweaks * Remove resolutions again Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Fix table for node16 (#1674) * do not merge this * update-jac-kit * update-jac-kit * remove visual flag * update jac-kit * Test workflow * Add confirmation before sending independent assessments request (#1648) * Revert "Merge branch 'main' into 1620-character-issues-google-doc-report" This reverts commit f6f14dd, reversing changes made to 2a38c4b. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk>
* Character Issues - Added a reason for recommendation field * Character Issues - status is now application-specific * no message * use node 12 * Revert "use node 12" This reverts commit ab6db30. * #1620 - character issues google doc report (#1624) * Character Issues - Added an Export to Google Doc button (that doesn't currently do anything) * Character Issues - renamed export to gogole doc button * character issues - export to google doc button now working * Bump protobufjs from 6.11.2 to 6.11.3 (#1640) Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eventsource from 1.1.0 to 1.1.1 (#1639) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Share Data answer in equality & diversity questions (#1634) * share data answer * share data answer * Bump version number to 0.88.0 * Lisias permissions (#1646) Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Allow/remove access for users (#1644) * remove addresses * add address * amend appCheck logic (#1654) * membership display and edit (#1633) * membership display and edit * redundancy for memberships being empty * redundancy for memberships being empty * fix-specific-memberships * removed commented code * #1641 Enable exercise team to select (and change) the advert type (#1645) * Enable exercise team to select the advert type Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Upgrade to use node 16 (#1652) * Update package, lint and jest config * Upgrade packages to use node 16 * Update workflows to use node 16 * Updated package-lock * upgrade to node v16.15.1 * Update workflows to use 16.15.1 * Roll back package lock * Remove resolutions, for now * Fix conflicts * Update package lock * Fix resolutions * Final tweaks * Remove resolutions again Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Fix table for node16 (#1674) * do not merge this * update-jac-kit * update-jac-kit * remove visual flag * update jac-kit * Test workflow * Add confirmation before sending independent assessments request (#1648) * Revert "Merge branch 'main' into 1620-character-issues-google-doc-report" This reverts commit f6f14dd, reversing changes made to 2a38c4b. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk>
* Character Issues - save actions * tidy-up * Candidate issues - added issue action filter * added an unassigned filter * renamed action to status * make sure 2nd dropdown is in the same line as the 1st * filtered not matching results * fixed unassigned result * Character Issues - status (and reason) now application-specific * no message * typo * no message * character issues - fixed filter * #1621 character issues - reason for recommendation (#1623) * Character Issues - Added a reason for recommendation field * Character Issues - status is now application-specific * no message * use node 12 * Revert "use node 12" This reverts commit ab6db30. * #1620 - character issues google doc report (#1624) * Character Issues - Added an Export to Google Doc button (that doesn't currently do anything) * Character Issues - renamed export to gogole doc button * character issues - export to google doc button now working * Bump protobufjs from 6.11.2 to 6.11.3 (#1640) Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.11.2 to 6.11.3. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@v6.11.2...v6.11.3) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump eventsource from 1.1.0 to 1.1.1 (#1639) Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Share Data answer in equality & diversity questions (#1634) * share data answer * share data answer * Bump version number to 0.88.0 * Lisias permissions (#1646) Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Allow/remove access for users (#1644) * remove addresses * add address * amend appCheck logic (#1654) * membership display and edit (#1633) * membership display and edit * redundancy for memberships being empty * redundancy for memberships being empty * fix-specific-memberships * removed commented code * #1641 Enable exercise team to select (and change) the advert type (#1645) * Enable exercise team to select the advert type Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Upgrade to use node 16 (#1652) * Update package, lint and jest config * Upgrade packages to use node 16 * Update workflows to use node 16 * Updated package-lock * upgrade to node v16.15.1 * Update workflows to use 16.15.1 * Roll back package lock * Remove resolutions, for now * Fix conflicts * Update package lock * Fix resolutions * Final tweaks * Remove resolutions again Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> * Bump version number to 0.89.0 * Fix table for node16 (#1674) * do not merge this * update-jac-kit * update-jac-kit * remove visual flag * update jac-kit * Test workflow * Add confirmation before sending independent assessments request (#1648) * Revert "Merge branch 'main' into 1620-character-issues-google-doc-report" This reverts commit f6f14dd, reversing changes made to 2a38c4b. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: tomlovesgithub <44227249+tomlovesgithub@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lloback@users.noreply.github.com> Co-authored-by: Lisias (Lee) Loback <lisias@loback.co.uk> Co-authored-by: warrensearle <warren@precise-minds.co.uk>
What's included?
This is part of main ticket number: #1641
Note: adding the
advertType
relies on changes to the digital-platform: jac-uk/digital-platform#732This feature enables exercise teams to better control which information is displayed on the vacancy list & details page.
There are 4 types available:
Listing should include:
Title
Launch date
Close date
Role summary
No “Apply” button
Basic should include:
Title
Launch date (may not be full date e.g., may need to put June 2022 or Autumn 2022)
Close date (optional preferably)
Number of vacancies
Appointment type (i.e., salaried/fee-paid, inc fee)
Location
Role summary
Yes - “Apply” button shows
Full should include:
Everything that is currently pulled through to adverts
Yes - “Apply” button shows
External should include:
Title
Timeline (will only have a launch date and close date)
About the role
No “Apply” button
Who should test?
✅ Product owner
✅ Developers
✅ UTG
How to test?
To test the feature go to https://jac-admin-develop--1641-lee-5zh4c1az.web.app/ and set up exercises in the 4 types shown above.
Then go to https://jac-apply-develop--1641-lee-glbw4d53.web.app/ to check all adverts are showing the correct information as per the list above.
A demo video can be seen here - https://drive.google.com/file/d/1fZBTI14NfUNg_FTcjhCcdWutR_9L3_9M/view?usp=sharing
Did the functionality work for you?
Where you able to set up exercises in the 4 different advert types?
Did it all save correctly?
Any other issues?
Any other comments or improvements needed?
Anything missing from an advert type?
Risk - how likely is this to impact other areas?
🟢 No risk - this is a self-contained piece of work
Additional context