Skip to content

Commit

Permalink
BUG: Update ITK to fix HDF5 symbol clash when import itk wheel
Browse files Browse the repository at this point in the history
List of ITK changes:

```
$ git shortlog --group=author --group=trailer:co-authored-by aacaefd63..e18566d53 --no-merges
Matt McCormick (2):
      [Backport] BUG: Update HDF5 name mangled symbols
      [Backport] DOC: Improve itk_hdf5_mangle.h.in instructions
```

This is expected to address errors like the following reported when
importing itk python package from a Linux Preview build of Slicer:

```
Thread 1 "SlicerApp-real" received signal SIGSEGV, Segmentation fault.
0x00007f34d7a3d58f in H5::Exception::~Exception() ()
   from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libitkhdf5_cpp-shared-5.4.so.1
(gdb) where
#0  0x00007f34d7a3d58f in H5::Exception::~Exception() ()
   from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libitkhdf5_cpp-shared-5.4.so.1
#1  0x00007f34fc8fdaff in ?? ()
   from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libITKCommon-5.4.so.1
Slicer#2  0x00007f30deed443c in itk::HDF5TransformIOTemplate<double>::Read() ()
   from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformHDF5Python.so
Slicer#3  0x00007f30e50787a3 in itk::TransformFileReaderTemplate<double>::Update() ()
   from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformBasePython.so
Slicer#4  0x00007f30e504c7cc in ?? ()
   from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformBasePython.so
Slicer#5  0x00007f34ecb02cf3 in ?? () from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Python/lib/libpython3.9.so
Slicer#6  0x00007f34eca76597 in ?? () from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Python/lib/libpython3.9.so
Slicer#7  0x00007f34eca7d070 in _PyEval_EvalFrameDefault ()
```
  • Loading branch information
jcfr committed Jul 3, 2024
1 parent 4c1546f commit c8ee59f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion SuperBuild/External_ITK.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if(NOT DEFINED ITK_DIR AND NOT Slicer_USE_SYSTEM_${proj})

ExternalProject_SetIfNotDefined(
Slicer_${proj}_GIT_TAG
"aacaefd6366bb09e09faefd173d4d3797f386ad0" # slicer-v5.4.0-2024-05-16-311b706
"e18566d53a1b8a913cd460e70569e9b485137fba" # slicer-v5.4.0-2024-05-16-311b706
QUIET
)

Expand Down

0 comments on commit c8ee59f

Please sign in to comment.