ENH: Update pre-commit hooks #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![slicer-app-test[bot]](https://avatars.githubusercontent.com/in/857940?s=60&v=4){kind=small}
slicer-app-test
bot
force-pushed
the
update/pre-commit-hooks
branch
from
5b859ba
to
901896c
Compare
jcfr
force-pushed
the
main
branch
3 times, most recently
from
6f93b2f
to
3a38484
Compare
updates: - [pre-commit/pre-commit-hooks: v4.4.0 -> v4.5](pre-commit/pre-commit-hooks@v4.4.0...v4.5) - [astral-sh/ruff-pre-commit: v0.1.3 -> v0.3](pre-commit/ruff-pre-commit@v0.1.3...v0.3) - [asottile/pyupgrade: v3.2.2 -> v3.15](pre-commit/pyupgrade@v3.2.2...v3.15)
slicer-app-test
bot
force-pushed
the
update/pre-commit-hooks
branch
from
901896c
to
84be739
Compare
jcfr
added a commit
that referenced
this pull request
Jul 3, 2024
List of ITK changes:
```
$ git shortlog --group=author --group=trailer:co-authored-by aacaefd63..e18566d53 --no-merges
Matt McCormick (2):
[Backport] BUG: Update HDF5 name mangled symbols
[Backport] DOC: Improve itk_hdf5_mangle.h.in instructions
```
This is expected to address errors like the following reported when
importing itk python package from a Linux Preview build of Slicer:
```
Thread 1 "SlicerApp-real" received signal SIGSEGV, Segmentation fault.
0x00007f34d7a3d58f in H5::Exception::~Exception() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libitkhdf5_cpp-shared-5.4.so.1
(gdb) where
#0 0x00007f34d7a3d58f in H5::Exception::~Exception() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libitkhdf5_cpp-shared-5.4.so.1
#1 0x00007f34fc8fdaff in ?? ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libITKCommon-5.4.so.1
Slicer#2 0x00007f30deed443c in itk::HDF5TransformIOTemplate<double>::Read() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformHDF5Python.so
Slicer#3 0x00007f30e50787a3 in itk::TransformFileReaderTemplate<double>::Update() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformBasePython.so
Slicer#4 0x00007f30e504c7cc in ?? ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformBasePython.so
Slicer#5 0x00007f34ecb02cf3 in ?? () from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Python/lib/libpython3.9.so
Slicer#6 0x00007f34eca76597 in ?? () from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Python/lib/libpython3.9.so
Slicer#7 0x00007f34eca7d070 in _PyEval_EvalFrameDefault ()
```
jcfr
added a commit
that referenced
this pull request
Aug 19, 2024
List of ITK changes:
```
$ git shortlog --group=author --group=trailer:co-authored-by aacaefd63..e18566d53 --no-merges
Matt McCormick (2):
[Backport] BUG: Update HDF5 name mangled symbols
[Backport] DOC: Improve itk_hdf5_mangle.h.in instructions
```
This is expected to address errors like the following reported when
importing itk python package from a Linux Preview build of Slicer:
```
Thread 1 "SlicerApp-real" received signal SIGSEGV, Segmentation fault.
0x00007f34d7a3d58f in H5::Exception::~Exception() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libitkhdf5_cpp-shared-5.4.so.1
(gdb) where
#0 0x00007f34d7a3d58f in H5::Exception::~Exception() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libitkhdf5_cpp-shared-5.4.so.1
#1 0x00007f34fc8fdaff in ?? ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Slicer-5.7/libITKCommon-5.4.so.1
Slicer#2 0x00007f30deed443c in itk::HDF5TransformIOTemplate<double>::Read() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformHDF5Python.so
Slicer#3 0x00007f30e50787a3 in itk::TransformFileReaderTemplate<double>::Update() ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformBasePython.so
Slicer#4 0x00007f30e504c7cc in ?? ()
from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/lib/Python/lib/python3.9/site-packages/itk/_ITKIOTransformBasePython.so
Slicer#5 0x00007f34ecb02cf3 in ?? () from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Python/lib/libpython3.9.so
Slicer#6 0x00007f34eca76597 in ?? () from /path/to/Slicer-5.7.0-2024-06-04-linux-amd64/bin/../lib/Python/lib/libpython3.9.so
Slicer#7 0x00007f34eca7d070 in _PyEval_EvalFrameDefault ()
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates:
This pull-request was auto-generated by the pre-commit-autoupdate GitHub action workflow.