5.0.0-rc.14: Pagination is broken #311
Comments
|
Looking now, thanks! Not sure how the tests didn't catch this 🤔 |
|
Found the problem! |
jdalrymple
added a commit
that referenced
this issue
May 10, 2019
|
Just released the fix! Give it a look when you have a chance |
jdalrymple
added a commit
that referenced
this issue
May 15, 2019
jdalrymple
pushed a commit
that referenced
this issue
May 25, 2019
## [4.5.2](4.5.1...4.5.2) (2019-05-25) ### Bug Fixes * Fixing pagination logic to handle Headers object correctly [#311](#311) ([a999545](a999545)) * Fixing request for recursive repository trees [#266](#266) ([6cc5bd9](6cc5bd9)) * Fixing up pagination logic to only be present when their is the possibility of multiple results ([96f448b](96f448b)) * Removing the camelizeKeys function on the response body ([7a4b477](7a4b477))
jdalrymple
added a commit
that referenced
this issue
May 25, 2019
…Files BREAKING CHANGE: Removed projectId from System Hooks API since it wasn't required BREAKING CHANGE: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument BREAKING CHANGE: Changing everything to named exports for simplicity BREAKING CHANGE: Switching required initialisation argument from 'url' to 'host' BREAKING CHANGE: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html BREAKING CHANGE: MergeRequest Pipelines require the mergeRequestId BREAKING CHANGE: NotificationSettings API edit function now takes one parameter, `options` BREAKING CHANGE: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 BREAKING CHANGE: Notes now require a body argument instead of checking the options argument for a body parameter BREAKING CHANGE: Triggers API pipeline function requires two new arguments, the ref and token feat: Added the ability to add sudo to specific requests (780244f (780244f)) feat: Added the missing edit function to the Groups API feat: Added LDAP support to the Groups API feat: Adding the option to conditionally camelize response body fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality fix: Fixing pagination logic to handle Headers object correctly #311 fix: Fixing up pagination logic to only be present when their is the possibility of multiple results fix: Fixing request for recursive repository trees #266 test: Modified maxPages test to better handle the issue seen in #311 docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this issue
May 25, 2019
…Files BREAKING CHANGE: Removed projectId from System Hooks API since it wasn't required BREAKING CHANGE: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument BREAKING CHANGE: Changing everything to named exports for simplicity BREAKING CHANGE: Switching required initialization argument from 'url' to 'host' BREAKING CHANGE: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html BREAKING CHANGE: MergeRequest Pipelines require the mergeRequestId BREAKING CHANGE: NotificationSettings API edit function now takes one parameter, `options` BREAKING CHANGE: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 BREAKING CHANGE: Notes now require a body argument instead of checking the options argument for a body parameter BREAKING CHANGE: Triggers API pipeline function requires two new arguments, the ref and token feat: Added the ability to add sudo to specific requests (780244f (780244f)) feat: Added the missing edit function to the Groups API feat: Added LDAP support to the Groups API feat: Adding the option to conditionally camelize response body fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality fix: Fixing pagination logic to handle Headers object correctly #311 fix: Fixing up pagination logic to only be present when their is the possibility of multiple results fix: Fixing request for recursive repository trees #266 test: Modified maxPages test to better handle the issue seen in #311 docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this issue
May 25, 2019
…Files BREAKING CHANGE: Removed projectId from System Hooks API since it wasn't required BREAKING CHANGE: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument BREAKING CHANGE: Changing everything to named exports for simplicity BREAKING CHANGE: Switching required initialization argument from 'url' to 'host' BREAKING CHANGE: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html BREAKING CHANGE: MergeRequest Pipelines require the mergeRequestId BREAKING CHANGE: NotificationSettings API edit function now takes one parameter, `options` BREAKING CHANGE: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 BREAKING CHANGE: Notes now require a body argument instead of checking the options argument for a body parameter BREAKING CHANGE: Triggers API pipeline function requires two new arguments, the ref and token feat: Added the ability to add sudo to specific requests (780244f (780244f)) feat: Added the missing edit function to the Groups API feat: Added LDAP support to the Groups API feat: Adding the option to conditionally camelize response body fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality fix: Fixing pagination logic to handle Headers object correctly #311 fix: Fixing up pagination logic to only be present when their is the possibility of multiple results fix: Fixing request for recursive repository trees #266 test: Modified maxPages test to better handle the issue seen in #311 docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this issue
May 25, 2019
jdalrymple
added a commit
that referenced
this issue
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Listing projects with pagination no longer works.
gitlab.Projects.all({ perPage: 100, maxPages: 100 })returns all projects from our Gitlab instance with 5.0.0-rc.13, but only 100 with 5.0.0-rc.14.The text was updated successfully, but these errors were encountered: