Fix array syntax to 'brackets'
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalrymple
added a commit
that referenced
this pull request
Oct 29, 2018
jdalrymple
added a commit
that referenced
this pull request
Oct 29, 2018
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jdalrymple
added a commit
that referenced
this pull request
Nov 11, 2018
jdalrymple
added a commit
that referenced
this pull request
Nov 13, 2018
breaking: Removed projectId from System Hooks API since it wasn't required breaking: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument breaking: Changing everything to named exports for simplicity breaking: Switching required initialization argument from 'url' to 'host' breaking: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html breaking: MergeRequest Pipelines require the mergeRequestId breaking: NotificationSettings API edit function now takes one parameter, `options` breaking: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 breaking: Notes now require a body argument instead of checking the options argument for a body parameter fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality feat: Adding the ability to add sudo to specific requests (780244f (780244f)) chore: Adding editorconfig file chore: Removing some overrides from the tslint chore: Removing unused dependencies chore: Adding prettier as a dev dependency docs: Removing xml request docs docs: Updating imports to be named imports
Merged
jdalrymple
added a commit
that referenced
this pull request
Nov 19, 2018
breaking: Removed projectId from System Hooks API since it wasn't required breaking: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument breaking: Changing everything to named exports for simplicity breaking: Switching required initialization argument from 'url' to 'host' breaking: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html breaking: MergeRequest Pipelines require the mergeRequestId breaking: NotificationSettings API edit function now takes one parameter, `options` breaking: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 breaking: Notes now require a body argument instead of checking the options argument for a body parameter fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality feat: Adding the ability to add sudo to specific requests (780244f (780244f)) chore: Adding editorconfig file chore: Removing some overrides from the tslint chore: Removing unused dependencies chore: Adding prettier as a dev dependency docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this pull request
Dec 11, 2018
breaking: Removed projectId from System Hooks API since it wasn't required breaking: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument breaking: Changing everything to named exports for simplicity breaking: Switching required initialization argument from 'url' to 'host' breaking: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html breaking: MergeRequest Pipelines require the mergeRequestId breaking: NotificationSettings API edit function now takes one parameter, `options` breaking: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 breaking: Notes now require a body argument instead of checking the options argument for a body parameter fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality feat: Adding the ability to add sudo to specific requests (780244f (780244f)) chore: Adding editorconfig file chore: Removing some overrides from the tslint chore: Removing unused dependencies chore: Adding prettier as a dev dependency docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this pull request
Dec 19, 2018
breaking: Removed projectId from System Hooks API since it wasn't required breaking: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument breaking: Changing everything to named exports for simplicity breaking: Switching required initialization argument from 'url' to 'host' breaking: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html breaking: MergeRequest Pipelines require the mergeRequestId breaking: NotificationSettings API edit function now takes one parameter, `options` breaking: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 breaking: Notes now require a body argument instead of checking the options argument for a body parameter fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality feat: Adding the ability to add sudo to specific requests (780244f (780244f)) chore: Adding editorconfig file chore: Removing some overrides from the tslint chore: Removing unused dependencies chore: Adding prettier as a dev dependency docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this pull request
May 8, 2019
breaking: Removed projectId from System Hooks API since it wasn't required breaking: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument breaking: Changing everything to named exports for simplicity breaking: Switching required initialization argument from 'url' to 'host' breaking: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html breaking: MergeRequest Pipelines require the mergeRequestId breaking: NotificationSettings API edit function now takes one parameter, `options` breaking: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 breaking: Notes now require a body argument instead of checking the options argument for a body parameter fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality feat: Added the ability to add sudo to specific requests (780244f (780244f)) feat: Added the missing edit function to the Groups API feat: Added LDAP support to the Groups API docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this pull request
May 25, 2019
…Files BREAKING CHANGE: Removed projectId from System Hooks API since it wasn't required BREAKING CHANGE: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument BREAKING CHANGE: Changing everything to named exports for simplicity BREAKING CHANGE: Switching required initialisation argument from 'url' to 'host' BREAKING CHANGE: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html BREAKING CHANGE: MergeRequest Pipelines require the mergeRequestId BREAKING CHANGE: NotificationSettings API edit function now takes one parameter, `options` BREAKING CHANGE: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 BREAKING CHANGE: Notes now require a body argument instead of checking the options argument for a body parameter BREAKING CHANGE: Triggers API pipeline function requires two new arguments, the ref and token feat: Added the ability to add sudo to specific requests (780244f (780244f)) feat: Added the missing edit function to the Groups API feat: Added LDAP support to the Groups API feat: Adding the option to conditionally camelize response body fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality fix: Fixing pagination logic to handle Headers object correctly #311 fix: Fixing up pagination logic to only be present when their is the possibility of multiple results fix: Fixing request for recursive repository trees #266 test: Modified maxPages test to better handle the issue seen in #311 docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this pull request
May 25, 2019
…Files BREAKING CHANGE: Removed projectId from System Hooks API since it wasn't required BREAKING CHANGE: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument BREAKING CHANGE: Changing everything to named exports for simplicity BREAKING CHANGE: Switching required initialization argument from 'url' to 'host' BREAKING CHANGE: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html BREAKING CHANGE: MergeRequest Pipelines require the mergeRequestId BREAKING CHANGE: NotificationSettings API edit function now takes one parameter, `options` BREAKING CHANGE: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 BREAKING CHANGE: Notes now require a body argument instead of checking the options argument for a body parameter BREAKING CHANGE: Triggers API pipeline function requires two new arguments, the ref and token feat: Added the ability to add sudo to specific requests (780244f (780244f)) feat: Added the missing edit function to the Groups API feat: Added LDAP support to the Groups API feat: Adding the option to conditionally camelize response body fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality fix: Fixing pagination logic to handle Headers object correctly #311 fix: Fixing up pagination logic to only be present when their is the possibility of multiple results fix: Fixing request for recursive repository trees #266 test: Modified maxPages test to better handle the issue seen in #311 docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this pull request
May 25, 2019
…Files BREAKING CHANGE: Removed projectId from System Hooks API since it wasn't required BREAKING CHANGE: Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument BREAKING CHANGE: Changing everything to named exports for simplicity BREAKING CHANGE: Switching required initialization argument from 'url' to 'host' BREAKING CHANGE: Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html BREAKING CHANGE: MergeRequest Pipelines require the mergeRequestId BREAKING CHANGE: NotificationSettings API edit function now takes one parameter, `options` BREAKING CHANGE: Changing the access level enum property from master to maintainer as per https://gitlab.com/gitlab-org/gitlab-ce/issues/42751 BREAKING CHANGE: Notes now require a body argument instead of checking the options argument for a body parameter BREAKING CHANGE: Triggers API pipeline function requires two new arguments, the ref and token feat: Added the ability to add sudo to specific requests (780244f (780244f)) feat: Added the missing edit function to the Groups API feat: Added LDAP support to the Groups API feat: Adding the option to conditionally camelize response body fix: #227 (#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) (f9bc34d (f9bc34d)) fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url (cbeef18 (cbeef18)) fix: ResourceAwardEmojis API wasn't properly filtering based on awardId (70f4315 (70f4315)) fix: Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality fix: Fixing pagination logic to handle Headers object correctly #311 fix: Fixing up pagination logic to only be present when their is the possibility of multiple results fix: Fixing request for recursive repository trees #266 test: Modified maxPages test to better handle the issue seen in #311 docs: Removing xml request docs docs: Updating imports to be named imports
jdalrymple
added a commit
that referenced
this pull request
May 25, 2019
jdalrymple
added a commit
that referenced
this pull request
May 25, 2019
jdalrymple
pushed a commit
that referenced
this pull request
May 25, 2019
# [5.0.0](4.5.1...5.0.0) (2019-05-25) ### Bug Fixes * [#227](#227) Fixing array syntax thanks to Lukas Eipert (https://github.com/leipert) ([aa6acb1](aa6acb1)) * Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url ([cea5a2b](cea5a2b)) * Fixing typing structure and configuration ([a79dabe](a79dabe)) * Merge Request Approvals API did not match official API ([e4ba731](e4ba731)) * Removed xhr library in favour of ky, and switched request for got for a smaller package size and retry functionality ([ee4730f](ee4730f)) * ResourceAwardEmojis API wasn't properly filtering based on awardId ([a7b29c1](a7b29c1)) ### Code Refactoring * Expose optional parameters for the NotiicationSettings API ([1ba9126](1ba9126)) * Removed Fs dependency for better browser support ([037f4ed](037f4ed)) * Removed inconsistent export strategies ([03e85ef](03e85ef)) * Removed the confusing url parameter from BaseService ([26e2e52](26e2e52)) * Requiring content for the Note related APIs ([7453779](7453779)) * Similar to the RepositoryFiles API changes ([97dd060](97dd060)) * SystemHooks API function header updates ([6ea90d3](6ea90d3)) * Triggers API required arguments exposed as optional ([62e032b](62e032b)) * Updating the MergeRequest API's pipeline function header ([46a541b](46a541b)) ### Features * Added LDAP support to the Groups API ([3f6d409](3f6d409)) * Added the ability to add sudo to specific requests ([18effa2](18effa2)) * Added the missing edit function to the Groups API ([ee6d490](ee6d490)) * Adding the option to conditionally camelize response body ([5f97193](5f97193)) ### BREAKING CHANGES * Triggers API pipeline function requires the ref and token * Notes now require a body argument * NotificationSettings API edit function now takes one parameter, `options` * MergeRequest Pipelines require the mergeRequestId * Updated Approvals API support to match https://docs.gitlab.com/ee/api/merge_request_approvals.html * Removed dependency on FS. Now the Projects API takes in two arguments `projectId` and `content` as well as an option fileName argument * Removed projectId from System Hooks API since it wasn't required * Added content as a required parameter for RepositoryFiles * Changing everything to named exports for simplicity * Switching required initialization argument from 'url' to 'host'
|
🎉 This issue has been resolved in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment arrays, like e.g.
iidsin issues are serialized wrong. For example:will be serialized as
when they should be serialized as