Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(updatecli): deduplicate manifest targets #444

Merged
merged 4 commits into from
Jul 1, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 28, 2023

This PR removes duplication with "jdk11" & "jdk17" targeting the same Dockerfiles.

Extract from #441

Testing done

Submitter checklist

Preview Give feedback

@lemeurherve lemeurherve requested a review from a team as a code owner June 28, 2023 16:38
@lemeurherve lemeurherve changed the title Cleanup duplication in updatecli manifests cleanup(updatecli): deduplicate manifest targets Jun 28, 2023
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, it fixes up #409 thanks!

One (nit) comment

@dduportal dduportal added the chore label Jul 1, 2023
lemeurherve and others added 2 commits July 1, 2023 17:33
@dduportal dduportal enabled auto-merge July 1, 2023 15:35
@dduportal dduportal merged commit 9210d2c into jenkinsci:master Jul 1, 2023
@lemeurherve lemeurherve deleted the cleanup-updatecli-manifest branch July 1, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants