Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

refactor: build docker-inbound-agent like docker-agent #363

Merged

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jul 8, 2023

This PR is a refactoring of the build process to be like https://github.com/jenkinsci/docker-agent (with recent refactoring jenkinsci/docker-agent#445) in order to facilitate introduction of new images.

Commits:

Testing done

https://ci.jenkins.io/job/Packaging/job/docker-inbound-agent/job/PR-363/69/

Submitter checklist

@lemeurherve lemeurherve changed the title wip: refactor Windows builds like docker agent wip: refactor docker-inbound-agent builds like docker-agent Jul 8, 2023
@lemeurherve lemeurherve force-pushed the refactor-windows-builds-like-docker-agent branch 2 times, most recently from 9125788 to 47662de Compare July 8, 2023 20:25
@lemeurherve lemeurherve force-pushed the refactor-windows-builds-like-docker-agent branch 6 times, most recently from ac54873 to 44ccf97 Compare July 9, 2023 09:16
@lemeurherve
Copy link
Member Author

lemeurherve commented Jul 9, 2023

@lemeurherve lemeurherve force-pushed the refactor-windows-builds-like-docker-agent branch 2 times, most recently from dc4cfa3 to 6ff0f03 Compare July 9, 2023 09:59
@lemeurherve lemeurherve changed the title wip: refactor docker-inbound-agent builds like docker-agent feat: refactor docker-inbound-agent builds like docker-agent Jul 9, 2023
@lemeurherve lemeurherve force-pushed the refactor-windows-builds-like-docker-agent branch from 3e2a639 to edf1c32 Compare July 9, 2023 11:08
@lemeurherve lemeurherve marked this pull request as ready for review July 9, 2023 11:11
@lemeurherve lemeurherve requested a review from a team as a code owner July 9, 2023 11:11
@lemeurherve lemeurherve marked this pull request as draft July 10, 2023 10:43
@lemeurherve lemeurherve force-pushed the refactor-windows-builds-like-docker-agent branch from edf1c32 to 0c44c26 Compare July 10, 2023 10:47
@dduportal
Copy link
Contributor

Can you resolve the conflicts (ideally rebasing) to ensure the review is done with an up-to-date code?

@lemeurherve lemeurherve force-pushed the refactor-windows-builds-like-docker-agent branch 4 times, most recently from 695e57f to 84ca2b1 Compare July 11, 2023 09:11
@lemeurherve lemeurherve force-pushed the refactor-windows-builds-like-docker-agent branch from 84ca2b1 to 6b35c96 Compare July 11, 2023 09:37
@lemeurherve lemeurherve marked this pull request as ready for review July 11, 2023 09:49
@lemeurherve
Copy link
Member Author

Tested in a replay with additional Windows 2022 images in https://ci.jenkins.io/job/Packaging/job/docker-inbound-agent/job/PR-363/71

--- old/Jenkinsfile
+++ new/Jenkinsfile
@@ -12,7 +12,7 @@
                 axes {
                     axis {
                         name 'AGENT_TYPE'
-                        values 'linux', 'windows-2019'
+                        values 'linux', 'windows-2019', 'windows-2022'
                     }
                 }
                 stages {

👉 PR ready for review

build.ps1 Outdated Show resolved Hide resolved
build.ps1 Outdated Show resolved Hide resolved
build.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve marked this pull request as ready for review July 12, 2023 11:01
build.ps1 Show resolved Hide resolved
@dduportal
Copy link
Contributor

  • Updatecli fails and should work once merged 👍
  • The failing Jenkins check is a remnant of failed build during a ci.jenkins.io restart: it does not matter

@dduportal dduportal merged commit 1862ea3 into jenkinsci:master Jul 28, 2023
4 of 5 checks passed
lemeurherve pushed a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Nov 19, 2023
…cefed9a9f428e724989dcd918a34ec9136afdf4f8b1c5b10f8f68

Bump JDK11 version to 11.0.18_10
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 12, 2024
…e/refactor-windows-builds-like-docker-agent

refactor: build `docker-inbound-agent` like `docker-agent`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants