This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 525
refactor: build docker-inbound-agent
like docker-agent
#363
Merged
dduportal
merged 18 commits into
jenkinsci:master
from
lemeurherve:refactor-windows-builds-like-docker-agent
Jul 28, 2023
Merged
refactor: build docker-inbound-agent
like docker-agent
#363
dduportal
merged 18 commits into
jenkinsci:master
from
lemeurherve:refactor-windows-builds-like-docker-agent
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
changed the title
wip: refactor Windows builds like docker agent
wip: refactor Jul 8, 2023
docker-inbound-agent
builds like docker-agent
lemeurherve
force-pushed
the
refactor-windows-builds-like-docker-agent
branch
2 times, most recently
from
July 8, 2023 20:25
9125788
to
47662de
Compare
lemeurherve
commented
Jul 8, 2023
lemeurherve
force-pushed
the
refactor-windows-builds-like-docker-agent
branch
6 times, most recently
from
July 9, 2023 09:16
ac54873
to
44ccf97
Compare
First part, using docker compose for Windows images like in https://github.com/jenkinsci/docker-agent OK: |
lemeurherve
force-pushed
the
refactor-windows-builds-like-docker-agent
branch
2 times, most recently
from
July 9, 2023 09:59
dc4cfa3
to
6ff0f03
Compare
lemeurherve
changed the title
wip: refactor
feat: refactor Jul 9, 2023
docker-inbound-agent
builds like docker-agent
docker-inbound-agent
builds like docker-agent
lemeurherve
force-pushed
the
refactor-windows-builds-like-docker-agent
branch
from
July 9, 2023 11:08
3e2a639
to
edf1c32
Compare
lemeurherve
force-pushed
the
refactor-windows-builds-like-docker-agent
branch
from
July 10, 2023 10:47
edf1c32
to
0c44c26
Compare
Can you resolve the conflicts (ideally rebasing) to ensure the review is done with an up-to-date code? |
lemeurherve
force-pushed
the
refactor-windows-builds-like-docker-agent
branch
4 times, most recently
from
July 11, 2023 09:11
695e57f
to
84ca2b1
Compare
lemeurherve
force-pushed
the
refactor-windows-builds-like-docker-agent
branch
from
July 11, 2023 09:37
84ca2b1
to
6b35c96
Compare
Tested in a replay with additional Windows 2022 images in https://ci.jenkins.io/job/Packaging/job/docker-inbound-agent/job/PR-363/71 --- old/Jenkinsfile
+++ new/Jenkinsfile
@@ -12,7 +12,7 @@
axes {
axis {
name 'AGENT_TYPE'
- values 'linux', 'windows-2019'
+ values 'linux', 'windows-2019', 'windows-2022'
}
}
stages { 👉 PR ready for review |
lemeurherve
commented
Jul 12, 2023
dduportal
reviewed
Jul 12, 2023
lemeurherve
commented
Jul 12, 2023
lemeurherve
commented
Jul 28, 2023
dduportal
approved these changes
Jul 28, 2023
|
This was referenced Jul 28, 2023
lemeurherve
pushed a commit
to lemeurherve/jenkinsci-docker-inbound-agent
that referenced
this pull request
Nov 19, 2023
…cefed9a9f428e724989dcd918a34ec9136afdf4f8b1c5b10f8f68 Bump JDK11 version to 11.0.18_10
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 28, 2023
…meurherve/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Jan 12, 2024
…e/refactor-windows-builds-like-docker-agent refactor: build `docker-inbound-agent` like `docker-agent`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring of the build process to be like https://github.com/jenkinsci/docker-agent (with recent refactoring jenkinsci/docker-agent#445) in order to facilitate introduction of new images.
Commits:
failFast
for parallel stages docker-agent#446timestamps()
call docker-agent#450Testing done
https://ci.jenkins.io/job/Packaging/job/docker-inbound-agent/job/PR-363/69/
Submitter checklist