Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(build): factorize Jenkinsfile steps #445

Merged
merged 25 commits into from
Jul 7, 2023
Merged

refactor(build): factorize Jenkinsfile steps #445

merged 25 commits into from
Jul 7, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 28, 2023 •
edited
Loading

This PR refactors Jenkinsfile steps in order to facilitate the introduction of Windows LTSC 2022 and future images like in #441.

As it would have been more difficult to do otherwise, it includes an evolution of the changes of #442 and #444.

Extract from #441 (comment),

I'd suggest reviewing (and hopefully merging) #442 then #444 then [this PR]

These PRs have since been merged.

Testing done

Replay with all tests passing: https://ci.jenkins.io/job/Packaging/job/docker-agent/job/PR-445/4/

Last version: https://ci.jenkins.io/job/Packaging/job/docker-agent/job/PR-445/55/

Submitter checklist
Preview Give feedback

@lemeurherve lemeurherve marked this pull request as ready for review June 28, 2023 22:49
@lemeurherve lemeurherve requested a review from a team as a code owner June 28, 2023 22:49
@lemeurherve lemeurherve mentioned this pull request Jun 28, 2023
Merged
@lemeurherve lemeurherve changed the title Refactor Jenkinsfile refactor(build): use matrix instead of parallel Jun 28, 2023
@lemeurherve lemeurherve changed the title refactor(build): use matrix instead of parallel refactor(build): factorize Jenkinsfile steps Jun 28, 2023
dduportal
dduportal reviewed Jul 1, 2023
View reviewed changes
@lemeurherve lemeurherve force-pushed the refactor-jenkinsfile branch from 75d1408 to 7ff704f Compare July 1, 2023 17:27
@lemeurherve @dduportal
use a single axis
e508106 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@lemeurherve lemeurherve requested a review from dduportal July 1, 2023 17:43
lemeurherve
lemeurherve commented Jul 6, 2023
View reviewed changes
lemeurherve
lemeurherve commented Jul 6, 2023
View reviewed changes
lemeurherve
lemeurherve commented Jul 6, 2023
View reviewed changes
@lemeurherve
Copy link
Member Author

lemeurherve commented Jul 6, 2023 •
edited
Loading

Successfully replayed in https://ci.jenkins.io/job/Packaging/job/docker-agent/job/PR-445/55/, ready for review 🙂

Nanoserver special case highlighted: image

dduportal
dduportal approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@dduportal
Copy link
Contributor

Merging as the only failing check is updatecli (that will run properly once merged)

@dduportal dduportal added the chore label Jul 7, 2023
@dduportal dduportal merged commit 4f712d2 into jenkinsci:master Jul 7, 2023
@dduportal dduportal mentioned this pull request Jul 7, 2023
Merged
@lemeurherve lemeurherve deleted the refactor-jenkinsfile branch July 7, 2023 17:03
This was referenced Jul 7, 2023
Merged
Merged
Merged
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 9, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
1a90292
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 9, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
dc4cfa3
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 9, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
6ff0f03
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 9, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
edf1c32
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 10, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
0c44c26
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 11, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
8316672
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 11, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
37481d8
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 11, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
695e57f
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 11, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
84ca2b1
lemeurherve added a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Jul 11, 2023
@lemeurherve
refactor builds like jenkinsci/docker-agent#445
6b35c96
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 27, 2023
@dduportal @lemeurherve
Merge pull request jenkinsci#445 from basil/remoting-args
a638aeb 
Migrate to new Remoting calling convention
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 27, 2023
@dduportal @lemeurherve
Merge pull request jenkinsci#445 from basil/remoting-args
705c2da 
Migrate to new Remoting calling convention
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Jan 11, 2024
@lemeurherve
refactor builds like jenkinsci#445
daaa122
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 11, 2024
@dduportal
Merge pull request jenkinsci#445 from basil/remoting-args
187e09b 
Migrate to new Remoting calling convention
lemeurherve added a commit to lemeurherve/docker-agent that referenced this pull request Jan 12, 2024
@lemeurherve
refactor builds like jenkinsci#445
07d810a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hervelemeur hervelemeur hervelemeur left review comments

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemeurherve @dduportal @hervelemeur