[4.0] Error in legacy plugins when method contains $event argument

[SharkyKZ]

Summary of Changes

Fixes legacy plugins being registered as modern plugins when method takes $event argument.

Testing Instructions

install and enable this plugin: plg_system_dummy.zip.

Actual result BEFORE applying this Pull Request

Argument 1 passed to PlgSystemDummy::onDummyTest() must be of the type string, object given

Expected result AFTER applying this Pull Request

No errors.

Documentation Changes Required

No.

[ChristineWk]

@SharkyKZ

Installed dummy plugin. Joomla 4.0.0-beta4
Before Patch:
0 Argument 1 passed to PlgSystemDummy::onDummyTest() must be of the type string, object given, called in /......./libraries/vendor/joomla/event/src/Dispatcher.php on line 495

Couldn't return to Dashboard & now site is broken.
Will install tomorrow a new fully nightly (4.0.0-beta5)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.}

[SharkyKZ]

That's expected behavior before patch.

[ChristineWk]

I have tested this item ✅ successfully on 7e7b73c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.}

[ChristineWk]

That's expected behavior before patch.

Of course, the message before patch was expected, but not, that my site becomes complety broken.

What I did:
At first I deleted the dummy plugin via phpMyAdmin successfully & backend was available again.
The possibility for an update tor 4.0.0-beta5 was shown > but unsuccessful, because got: AJAX Loading error ...
(Correct server nightly xml)

Therefore I deleted space/database and installed fully nightly 4.0.0-beta5 plus Patchtester etc.
Then activated this Patch (did not check now message before Patch :-)
Installed your Dummy plugin and Result: No failure/message.

[ChristineWk]

Hmmm: After successful Patch (see above) I reverted it and got the failure again. Backend broken now.
Will try to delete dummy Plugin via phpMyAdmin again.

For other testers: Please before reverting Patch: de-active Plugin ....

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.}

[SharkyKZ]

I hope you're not testing on live site 😅

[ChristineWk]

I hope you're not testing on live site 😅

It's a live site (space), but for testing purposes only of course :-)
Will never forget your plugin -hv deleted it now :-)

[jwaisner]

I have tested this item ✅ successfully on 7e7b73c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.}

[jwaisner]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.}

[laoneo]

Conflicts here...

[SharkyKZ]

Conflicts fixed.

[SharkyKZ]

Last commit changes condition order for optimization. No change in functionality.

[laoneo]

Thanks!