Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Modifying com_actionlogs string #30758

Merged
merged 4 commits into from
Sep 26, 2020

Conversation

infograf768
Copy link
Member

Summary of Changes

To help translators and non-coders, replacing the confusing value

COM_ACTIONLOGS_LOG_VERBS_LABEL="Verbs To Log"
by
COM_ACTIONLOGS_LOG_VERBS_LABEL="HTTP Request Method"

as both means the same.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 24, 2020
@brianteeman
Copy link
Contributor

Would it be even simpler for translators without the HTTP as thats not needed either in this context

COM_ACTIONLOGS_LOG_VERBS_LABEL="Request Method"

@infograf768
Copy link
Member Author

See https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods

and French equivalent

https://developer.mozilla.org/fr/docs/Web/HTTP/M%C3%A9thode

Including HTTP is fine in all languages.

@alikon
Copy link
Contributor

alikon commented Sep 24, 2020

from https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods

HTTP defines a set of request methods to indicate the desired action to be performed for a given resource. Although they can also be nouns, these request methods are sometimes referred to as HTTP verbs.

don't forget that that text is only displayed if you switch on yes from Log API Requests

but i'll let you to find the best understandable words

@brianteeman
Copy link
Contributor

HTTP should not be translated in any language and its a redundant word

@ceford
Copy link
Contributor

ceford commented Sep 25, 2020

Two comments:

As this is a multi-select field it needs to be plural, so "HTTP Request Methods"

The label above that reveals this field when set to Yes says "Log API Requests". So...

I suggest "Request methods to log"

Being unfamiliar with the term 'Verbs' it makes more sense to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30758.

@infograf768
Copy link
Member Author

Modified to Request Methods To Log as requested.

@joomlacorner
Copy link
Contributor

I have tested this item ✅ successfully on 5bbf249

patch worked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30758.

@ceford
Copy link
Contributor

ceford commented Sep 26, 2020

I have tested this item ✅ successfully on 5bbf249

It looks fine on my screen. Putting HTTP at the front would have caused a space problem.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30758.

@infograf768 infograf768 added this to the Joomla 4.0 milestone Sep 26, 2020
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Sep 26, 2020
@infograf768
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30758.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 26, 2020
@HLeithner HLeithner merged commit 1ba351f into joomla:4.0-dev Sep 26, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 26, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Sep 26, 2020
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 26, 2020
* Joomla/4.0-dev: (844 commits)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  Removing card.scss overrides as we don't use those classes
  Use renderField() method to render fields (joomla#30738)
  [4.0] spelling (joomla#30742)
  [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581)
  [4.0] Fix saving images (joomla#30730)
  [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729)
  Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710)
  [4.0] Fix Debug plugin to display query parameters (joomla#30717)
  ...
@infograf768 infograf768 deleted the 4.0_actionlogs_string_value branch September 26, 2020 17:06
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…ger_events_consistency

* '4.0-dev' of github.com:joomla/joomla-cms: (84 commits)
  [4.0] Error in legacy plugins when method contains $event argument (joomla#30575)
  [4.0] Cassiopea table css (joomla#30740)
  [4.0] Blog view links (joomla#30788)
  Change grid minmax definition for newsflash module (joomla#30781)
  [4.0] Pluginless lazyloading for the core (joomla#30748)
  Update package-lock.json (joomla#30713)
  [4.0] mod_article_news readmore (joomla#30780)
  Improve code, remove separator (joomla#30785)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  ...

� Conflicts:
�	administrator/components/com_media/resources/scripts/app/Api.js
�	administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue
�	package-lock.json
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants