-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Update NPM dependencies #30713
Merged
HLeithner
merged 1 commit into
joomla:4.0-dev
from
richard67:4.0-dev-update-npm-dependencies-2020-09-21
Sep 27, 2020
Merged
[4.0] Update NPM dependencies #30713
HLeithner
merged 1 commit into
joomla:4.0-dev
from
richard67:4.0-dev-update-npm-dependencies-2020-09-21
Sep 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on ca69671 Confirmed on clean install that no issues occurred. Installed sample data with no issues. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713. |
I have tested this item ✅ successfully on ca69671 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713. |
Thanks |
dgrammatiko
added a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Sep 29, 2020
…ger_events_consistency * '4.0-dev' of github.com:joomla/joomla-cms: (84 commits) [4.0] Error in legacy plugins when method contains $event argument (joomla#30575) [4.0] Cassiopea table css (joomla#30740) [4.0] Blog view links (joomla#30788) Change grid minmax definition for newsflash module (joomla#30781) [4.0] Pluginless lazyloading for the core (joomla#30748) Update package-lock.json (joomla#30713) [4.0] mod_article_news readmore (joomla#30780) Improve code, remove separator (joomla#30785) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) ... � Conflicts: � administrator/components/com_media/resources/scripts/app/Api.js � administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue � package-lock.json
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Update NPM dependencies to latest suitable version with respect to semver.
Mainly it is an update for canisuelite and a few bugfixes or security updates for other packages.
Re-do of PR #30693 .
Thanks @brianteeman for the initial version.
Testing Instructions
Preparation: Make sure that the command shell window you will use to run npm has a sufficient scroll back history so the output of npm will not be lost.
Verify that there are no unexpected changes resulting in an unresolved reference (
"resolved": ""
).Verify that no package will be removed.
package-lock.json
file in the Joomla root folder by the one from this PR.composer install
if you haven't done that before.npm ci
and watch the output of that command.build:js
step.Actual result BEFORE applying this Pull Request
npm ci
works without unexpected warnings or errors.Expected result AFTER applying this Pull Request
Same as actual result.
Backend and frontend work as well as before.
Documentation Changes Required
None.