Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Update NPM dependencies #30713

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Sep 21, 2020

Pull Request for Issue # .

Summary of Changes

Update NPM dependencies to latest suitable version with respect to semver.

Mainly it is an update for canisuelite and a few bugfixes or security updates for other packages.

Re-do of PR #30693 .

Thanks @brianteeman for the initial version.

Testing Instructions

Preparation: Make sure that the command shell window you will use to run npm has a sufficient scroll back history so the output of npm will not be lost.

  1. Check the changes of this PR on GitHub. You have to expand the file with the "Load diff" link.
    Verify that there are no unexpected changes resulting in an unresolved reference ("resolved": "").
    Verify that no package will be removed.
  2. Verify that system tests for this PR were passing in Drone.
  3. On a clean 4.0-dev branch, apply the changes of this PR or simply replace the package-lock.json file in the Joomla root folder by the one from this PR.
  4. Run composer install if you haven't done that before.
  5. Run npm ci and watch the output of that command.
  6. Verify that no unusual warnings or errors are issued by npm at the first step when it fetches the external packages before starting the build:js step.
  7. Make a new installation.
  8. Login to backend and check if things work as usual.
  9. Install some kind of sample data to have some frontend content.
  10. Check on frontend if everything works as usual.

Actual result BEFORE applying this Pull Request

npm ci works without unexpected warnings or errors.

Expected result AFTER applying this Pull Request

Same as actual result.

Backend and frontend work as well as before.

Documentation Changes Required

None.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 21, 2020
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on ca69671

NPM CI had no errors and no packages were removed.

Confirmed on clean install that no issues occurred.

Installed sample data with no issues.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713.

@alikon
Copy link
Contributor

alikon commented Sep 27, 2020

I have tested this item ✅ successfully on ca69671


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 27, 2020
@alikon
Copy link
Contributor

alikon commented Sep 27, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30713.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 27, 2020
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 27, 2020
@HLeithner HLeithner merged commit 38b1c29 into joomla:4.0-dev Sep 27, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 27, 2020
@HLeithner
Copy link
Member

Thanks

@HLeithner HLeithner added this to the Joomla 4.0 milestone Sep 27, 2020
@richard67 richard67 deleted the 4.0-dev-update-npm-dependencies-2020-09-21 branch September 27, 2020 13:48
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…ger_events_consistency

* '4.0-dev' of github.com:joomla/joomla-cms: (84 commits)
  [4.0] Error in legacy plugins when method contains $event argument (joomla#30575)
  [4.0] Cassiopea table css (joomla#30740)
  [4.0] Blog view links (joomla#30788)
  Change grid minmax definition for newsflash module (joomla#30781)
  [4.0] Pluginless lazyloading for the core (joomla#30748)
  Update package-lock.json (joomla#30713)
  [4.0] mod_article_news readmore (joomla#30780)
  Improve code, remove separator (joomla#30785)
  [4.0] Template layout select (joomla#30772)
  [4.0][CLI] com_finder use console command (joomla#30768)
  [4.0] Modifying com_actionlogs string (joomla#30758)
  [4.0] Fancy selectbox fix (joomla#30739)
  [4.0] Add missing Table Caption (joomla#30763)
  [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761)
  [4.0] Cassiopeia missing string (joomla#30765)
  Improve batch text (joomla#28447)
  Fix icons not displaying (joomla#30749)
  Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734)
  Remove obsolete html code (joomla#30737)
  [4.0] Check out improvements related to nullable columns (joomla#30747)
  ...

� Conflicts:
�	administrator/components/com_media/resources/scripts/app/Api.js
�	administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue
�	package-lock.json
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants