[4.1-dev] Fixing SCSS issues with division deprecation and math.div() #35645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the skipto js to the newly released 4.1.2 ### Version 4.1.2 Added aria-busy="true" attribute to menu element when SkipTo is initialized and being updated with new menu items to support validators looking for required menu items for the menu role. Added the optional aria-controls attribute to button element to reference the id of the menu element as defined in the W3C ARIA Authoring practices for menu button pattern. ### Version 4.1.1 Removed aria-describedby from button, since screen readers read the accesskey information.
If you do not have the track session metadata option enabled in global configuration then the admin module for Logged Users displays an appropriate message. This PR simply styles the module output correctly to be consistent
* [J4] Adds support for custom class on subforms via xml * [J4] Adds support for custom class on subforms via xml
See https://www.tiny.cloud/docs/changelog/ for details This includes 5.9.0, 5.9.1 and 5.9.2
…ig.xml of the respective component. (#35479) Co-authored-by: Thomas Hunziker <werbemails@bakual.ch>
* Update main.php * Update Bootstrap.php
joomla-cms-bot
added
NPM Resource Changed
thednp
changed the title
|
@dgrammatiko and any other please test and push this. |
|
If you want it to be merged into 4.0 then you should do the pr on that branch and not 4.1 From your description it implies that its just for fontawesome but I see in the files that it applies elsewhere. Please confirm and update your initial post and test instructions |
|
I need this in 4.1 for #35639. It is for fontawesome mainly, but also some other minor changes to pass the compiler. As you can see for yourself. So close commit and re-commit to 4.0? and then someone else will merge the change to 4.1? 4.1 branch is important to get that PR solved. |
You don't have to close and reopen you can rebase it to 4.0-dev, eg click on the edit next to the PR's title and then select the branch |
|
I can't do that right now, I'm still working with GH app on the color-picker branch. |
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
* Add a new Icon for com_tags to the quicicon module * Update administrator/language/en-GB/com_tags.ini Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Brian Teeman <brian@teeman.net>
…1675) * Actionlogs: Added parameter to disable relative timestamps. * Update administrator/components/com_actionlogs/config.xml Co-authored-by: Quy <quy@fluxbb.org> * Apply suggestions from code review Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Quy <quy@fluxbb.org>
* log:logDeprecated * use new log method * new log method, improve callStack lookup * phpcs * phpcs * Check deprecation logging on boot * trigger_error everywhere * use namespaced classes
* add Joomla! Accessibility Team to the code owners * add cassiopeia * add everything in the templates
a fix for #35639
joomla-cms-bot
added
Unit/System Tests
and removed
NPM Resource Changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for PR #35639 .
Important
This PR should be merged into [4.0-dev] as well asap.
Summary of Changes
The fontawesome icon library haven't marked their
$fa-fw-widthvariable with!default, see #17482 which uses(20em / 16)expression which is deprecated in dart-sass 2.0 and also largely reported in the fontawesome issues.Other changes in this PR also address other dart-sass issues, but we don't replace for instance
24 / 16withmath.div(24, 16)as recommended by the compiler, but with24 * 0.0625(which is the result of 1/16) and the reason for that is the libsass compiler still largely used and this approach is also widely adopted. I suspect scssPhp also might not havemathimplemented.See this PR in fontawesome
for more info.
Testing Instructions
Just build and check SASS compiler output.
Actual result BEFORE applying this Pull Request
The compiler just won't do division via the
/(forward slash) operatorhttps://ci.joomla.org/joomla/joomla-cms/47599
Expected result AFTER applying this Pull Request
All scss files compiled successful.
Documentation Changes Required
No.