Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Dark Mode final Version #42986

Merged
merged 306 commits into from
Mar 11, 2024
Merged

[5.1] Dark Mode final Version #42986

merged 306 commits into from
Mar 11, 2024

Conversation

coolcat-creations
Copy link
Contributor

@coolcat-creations coolcat-creations commented Mar 9, 2024 •
edited by richard67
Loading

This is a follow up of #42757 and #42010 for Joomla 5.1

Summary of Changes

Dark mode modifications and improvements

Testing Instructions

Turn on dark mode in your browser or O/S

Actual result BEFORE applying this Pull Request

old dark mode

Expected result AFTER applying this Pull Request

improved dark mode

MacJoom and others added 30 commits October 9, 2023 23:28
@MacJoom
cs
de5682a
@MacJoom
joomla-alert fixes
80bc98f
@MacJoom
sidebar dark mode fixes
75cd44a
@MacJoom
cs
a20ea94
@MacJoom
cs
d94a3ff
@MacJoom
table & icon dark mode
cb149c9
@MacJoom
cs
ca34fb4
@MacJoom
toolbar subhead buttons darkmode
b3617cd
@MacJoom
toolbar buttons dark mode
69400d5
@MacJoom
Fix Joomla Alert background
3677957
@MacJoom
cpanel list group item links
35ea658
@MacJoom
Merge branch '5.0-dev' into dark-mode-5.0-dev
0a8a1d5
@MacJoom
cpanel btn-info quickicon success hover
f9d4f7f
@MacJoom
com_media - Fix Part 1
53a50cf
@MacJoom
com_media - Fix Part 2
7ef0dd4
@MacJoom @brianteeman
Apply suggestions from code review
9ae6e49 
CS - thanks for the suggestions

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
3f2feb7 
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
9ccdb06 
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
36d3336 
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
b314075 
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
2175bbc 
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
29c9ba9 
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom
panel bg fixes, get rid of hue part 1
b00e59e
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
49c0014 
…s-dark.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom @brianteeman
Update build/media_source/templates/administrator/atum/scss/_variable…
ec8e364 
…s.scss

Co-authored-by: Brian Teeman <brian@teeman.net>
@MacJoom
Merge branch '5.0-dev' into dark-mode-5.0-dev
ebe57dd
@MacJoom
Button Borders, Form-select borders
b2366c4
@MacJoom
Custom forms buttons borders
8a95008
@MacJoom
fix danger disabled button border
627cbe6
@MacJoom
fix danger disabled button border
ab4c3bf
@Quy
Copy link
Contributor

Quy commented Mar 10, 2024

#42506

Install the plugin.
Go to Extensions.
Find switch.
Click a button under Version.

pkg_switcheditor_2-2.2.4.zip

@brianteeman
Copy link
Contributor

image

image

@coolcat-creations
Copy link
Contributor Author

LTR

image

RTL

image

Same issue repeated in dark mode

fixed for darkmode, lightmode needs to go into separate PR

@LadySolveig LadySolveig merged commit 985b174 into joomla:5.1-dev Mar 11, 2024
3 checks passed
@LadySolveig
Copy link
Contributor

Thank you very much for the great work and your commitment @coolcat-creations and @MacJoom ! 💟 🚀
Many thanks also to all those who participated in testing and provided feedback - great to see this wonderful collaboration.

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Mar 11, 2024
@Quy Quy mentioned this pull request Mar 11, 2024
Closed
@brianteeman brianteeman mentioned this pull request Mar 11, 2024
Merged
4 tasks
This was referenced Mar 11, 2024
Closed
Merged
@Kostelano
Copy link
Contributor

System --> Guided Tours, when hovering the cursor

Screenshot_1

@coolcat-creations
Copy link
Contributor Author

@Kostelano thank you for the finding. As this is merged, can you please open a new issue ?

@heelc29 heelc29 mentioned this pull request Mar 17, 2024
Closed
@LadySolveig LadySolveig mentioned this pull request Mar 20, 2024
Merged
4 tasks
@coolcat-creations coolcat-creations mentioned this pull request Mar 22, 2024
Merged
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 2, 2024
@Kostelano
Новое в Joomla 5.1.0-RC1
7bb8b21 
joomla/joomla-cms#42966 - (только для en-GB)
joomla/joomla-cms#42953 +
joomla/joomla-cms#42986 +
joomla/joomla-cms#42221 +
joomla/joomla-cms#41659 +
joomla/joomla-cms#43061 +
joomla/joomla-cms#43054 - (только для en-GB)
joomla/joomla-cms#42995 - (только для en-GB)
joomla/joomla-cms#43115 +
joomla/joomla-cms#43147 +
+ Upmerge
@brianteeman brianteeman mentioned this pull request Sep 24, 2024
Closed
@brianteeman brianteeman mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmst chmst Awaiting requested review from chmst

Assignees
No one assigned
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Milestone
Joomla! 5.1.0
Development

Successfully merging this pull request may close these issues.
9 participants
@coolcat-creations @brianteeman @Quy @korenevskiy @LadySolveig @Kostelano @joomla-cms-bot @MacJoom @bembelimen