-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Remove TODO joomla-alert.scss #44274
Conversation
While reviewing existing @todo I came across these two. The first one is not needed as the variable has the same value The second one makes no sense @coolcat-creations these where your todo comments - have I missed something or can they simply be removed Signed-off-by: BrianTeeman <brian@teeman.net>
Resolve todo as we only support php8 now. This should probably have been done when I did joomla#41855 Original PR where this check was added joomla#28694 Signed-off-by: BrianTeeman <brian@teeman.net>
This reverts commit 485596d.
Sorry I don't understand these TODOS anymore ;( |
Thanks for confirming. You are not alone of the 300+ todo many of them make no sense at all and have been there for a very very long time |
@brianteeman I wanted to test by download prepbuild package as it has the "NPM Resource Changed" label but could not find |
@fgsw files in the build/ folder and not distributed. They are used to create the css files found in the media/ folder |
Thanks for information that the pull request can't get a test by prebuilt package. |
I agree that todos are often not useful, I will put this on the maintainers agenda, I think a todo should contain a version we have to work on the todo, a description and maybe a reason. |
@rdeutz in this specific case the person who wrote the todo states she doesnt know why |
understandable after months/years, if we force people to write more about the todo changes are goodl that they know why |
Thanks |
hence my comment on your todo yesterday ;) |
While reviewing existing @todo I came across these two.
The first one is not needed as the variable has the same value The second one makes no sense
@coolcat-creations these were your todo comments from #42986 - have I missed something or can they simply be removed
Testing Instructions
code review