Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Simplify notification labels #2171

Closed
jgerman-bot opened this issue Dec 10, 2021 · 0 comments · Fixed by #2166
Closed

[4.1] Simplify notification labels #2171

jgerman-bot opened this issue Dec 10, 2021 · 0 comments · Fixed by #2166

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#36271 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/plg_system_tasknotification.ini b/administrator/language/en-GB/plg_system_tasknotification.ini
index 33e6f6bbcf83..d94cfe5d028f 100644
--- a/administrator/language/en-GB/plg_system_tasknotification.ini
+++ b/administrator/language/en-GB/plg_system_tasknotification.ini
@@ -8,10 +8,10 @@ PLG_SYSTEM_TASK_NOTIFICATION_FAILURE_MAIL_BODY="Hello,\n\n\nPlanned execution of
 PLG_SYSTEM_TASK_NOTIFICATION_FAILURE_MAIL_SUBJECT="Task Failure"
 PLG_SYSTEM_TASK_NOTIFICATION_FATAL_MAIL_BODY="Hello,\n\nPlanned execution of Scheduler Task#{TASK_ID}, {TASK_TITLE}, recovered from a fatal failure.\n\nThis could mean that the task execution exhausted the system resources or the restrictions from the PHP INI.\n\nPlease visit the Joomla! backend for more information."
 PLG_SYSTEM_TASK_NOTIFICATION_FATAL_MAIL_SUBJECT="Task Recover from Fatal Failure"
-PLG_SYSTEM_TASK_NOTIFICATION_LABEL_FAILURE_MAIL_TOGGLE="Notifications on Task Failure"
-PLG_SYSTEM_TASK_NOTIFICATION_LABEL_FATAL_FAILURE_MAIL_TOGGLE="Notifications on Fatal Failures/Crashes (Recommended)"
-PLG_SYSTEM_TASK_NOTIFICATION_LABEL_ORPHANED_TASK_MAIL_TOGGLE="Notifications on Orphaned Tasks (Recommended)"
-PLG_SYSTEM_TASK_NOTIFICATION_LABEL_SUCCESS_MAIL_TOGGLE="Notifications on Task Success"
+PLG_SYSTEM_TASK_NOTIFICATION_LABEL_FAILURE_MAIL_TOGGLE="Task Failure"
+PLG_SYSTEM_TASK_NOTIFICATION_LABEL_FATAL_FAILURE_MAIL_TOGGLE="Fatal Failures/Crashes (Recommended)"
+PLG_SYSTEM_TASK_NOTIFICATION_LABEL_ORPHANED_TASK_MAIL_TOGGLE="Orphaned Tasks (Recommended)"
+PLG_SYSTEM_TASK_NOTIFICATION_LABEL_SUCCESS_MAIL_TOGGLE="Task Success"
 PLG_SYSTEM_TASK_NOTIFICATION_NO_MAIL_SENT="Could not send task notification to any user. This either means that mailer is not set up properly or no user with system emails enabled, com_scheduler `core.manage` privilege exists."
 PLG_SYSTEM_TASK_NOTIFICATION_ORPHAN_MAIL_BODY="Hello,\n\nScheduled Task#{TASK_ID}, {TASK_TITLE}, has been orphaned. This likely means that the provider plugin was removed or disabled from your Joomla! installation.\n\nPlease visit the Joomla! backend to investigate."
 PLG_SYSTEM_TASK_NOTIFICATION_ORPHAN_MAIL_SUBJECT="New Orphaned Task"
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Dec 11, 2021
@tecpromotion tecpromotion added this to the 4.1.0.v1 milestone Dec 11, 2021
zero-24 added a commit that referenced this issue Jan 15, 2022
* add new files and new strings

* fix #2157

* fix #2160

* fix #2158

* fix #2159

* fix #2161

* fix #2170

add two new strings

* fix #2171

* fix #2172

* fix #2173

* add translation plg_task_checkfiles

* add translation plg_task_demotask

* translation part 1

* fix #2179

* fix #2175

* fix #2196

* fix #2195

* just happy new year head

* translation plg_system_schedulerunner

* translation plg_system_tasknotification

* translation plg_task_requests

* language style

* translation plg_task_sitestatus

* translation plg_actionlog_joomla

* sounds better

* sounds nicer

* Update administrator/language/de-DE/plg_system_tasknotification.ini

thanks @zero-24

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* fix output

* language style

* fix #2220

* add new strings #2222

* fix #2222

* Update administrator/language/de-DE/com_scheduler.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants