Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Scheduled tasks notes #2175

Closed
jgerman-bot opened this issue Dec 13, 2021 · 0 comments
Closed

[4.1] Scheduled tasks notes #2175

jgerman-bot opened this issue Dec 13, 2021 · 0 comments

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#36244 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/components/com_scheduler/tmpl/tasks/default.php b/administrator/components/com_scheduler/tmpl/tasks/default.php
index 196203e53442..03a50d6167fe 100644
--- a/administrator/components/com_scheduler/tmpl/tasks/default.php
+++ b/administrator/components/com_scheduler/tmpl/tasks/default.php
@@ -200,13 +200,11 @@ class="js-draggable" data-url="<?php echo $saveOrderingUrl; ?>" data-direction="
 								<?php echo $this->escape($item->title); ?>
 							<?php endif; ?>
 
-							<span class="small">
-								<?php if (empty($item->note)): ?>
-									<?php echo Text::_('COM_SCHEDULER_NO_NOTE'); ?>
-								<?php else: ?>
+							<?php if ($item->note): ?>
+								<span class="small">
 									<?php echo Text::sprintf('JGLOBAL_LIST_NOTE', $this->escape($item->note)); ?>
-								<?php endif; ?>
-							</span>
+								</span>
+							<?php endif; ?>
 						</th>
 
 						<!-- Item type -->
diff --git a/administrator/language/en-GB/com_scheduler.ini b/administrator/language/en-GB/com_scheduler.ini
index dd695145ac2c..510245c8d05b 100644
--- a/administrator/language/en-GB/com_scheduler.ini
+++ b/administrator/language/en-GB/com_scheduler.ini
@@ -85,7 +85,6 @@ COM_SCHEDULER_MANAGER_TASK_EDIT="Edit Task"
 COM_SCHEDULER_MANAGER_TASK_NEW="New Task"
 COM_SCHEDULER_MSG_MANAGE_NO_TASK_PLUGINS="There are no task types matching your query!"
 COM_SCHEDULER_NEW_TASK="New Task"
-COM_SCHEDULER_NO_NOTE=""
 COM_SCHEDULER_N_ITEMS_DELETED="%d tasks deleted."
 COM_SCHEDULER_N_ITEMS_DELETED_1="Task deleted."
 COM_SCHEDULER_N_ITEMS_FAILED_UNLOCKING="Failed to unlock %d tasks."
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Dec 17, 2021
@tecpromotion tecpromotion added this to the 4.1.0.v1 milestone Dec 17, 2021
zero-24 added a commit that referenced this issue Jan 15, 2022
* add new files and new strings

* fix #2157

* fix #2160

* fix #2158

* fix #2159

* fix #2161

* fix #2170

add two new strings

* fix #2171

* fix #2172

* fix #2173

* add translation plg_task_checkfiles

* add translation plg_task_demotask

* translation part 1

* fix #2179

* fix #2175

* fix #2196

* fix #2195

* just happy new year head

* translation plg_system_schedulerunner

* translation plg_system_tasknotification

* translation plg_task_requests

* language style

* translation plg_task_sitestatus

* translation plg_actionlog_joomla

* sounds better

* sounds nicer

* Update administrator/language/de-DE/plg_system_tasknotification.ini

thanks @zero-24

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* fix output

* language style

* fix #2220

* add new strings #2222

* fix #2222

* Update administrator/language/de-DE/com_scheduler.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants