Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1 Scheduled Tasks] Unused constants #2195

Closed
jgerman-bot opened this issue Dec 31, 2021 · 1 comment
Closed

[4.1 Scheduled Tasks] Unused constants #2195

jgerman-bot opened this issue Dec 31, 2021 · 1 comment

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#36480 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/com_scheduler.ini b/administrator/language/en-GB/com_scheduler.ini
index a54b1c9156b7..42bcbf67dbd8 100644
--- a/administrator/language/en-GB/com_scheduler.ini
+++ b/administrator/language/en-GB/com_scheduler.ini
@@ -68,9 +68,7 @@ COM_SCHEDULER_LABEL_EXEC_DAY="Execution Day"
 COM_SCHEDULER_LABEL_EXEC_INTERVAL="Execution Interval"
 COM_SCHEDULER_LABEL_EXEC_TIME="Execution Time (UTC)"
 COM_SCHEDULER_LABEL_EXIT_CODE="Last Exit Code"
-COM_SCHEDULER_LABEL_HOURS="Hours"
 COM_SCHEDULER_LABEL_LAST_EXEC="Last Executed"
-COM_SCHEDULER_LABEL_MINUTES="Minutes"
 COM_SCHEDULER_LABEL_NEXT_EXEC="Next Execution"
 COM_SCHEDULER_LABEL_NOTES="Note"
 COM_SCHEDULER_LABEL_TASK_PRIORITY="Priority"
@@ -110,13 +108,8 @@ COM_SCHEDULER_SCHEDULER_TASK_LOCKED="task#%1$02d is locked."
 COM_SCHEDULER_SCHEDULER_TASK_ROUTINE_NA="Task#%1$02d has no corresponding plugin routine. The plugin might have been disabled or removed. Skipping execution."
 COM_SCHEDULER_SCHEDULER_TASK_START="Running task#%1$02d '%2$s'."
 COM_SCHEDULER_SCHEDULER_TASK_UNKNOWN_EXIT="Task#%1$02d exited with code %4$d in %2$.2f (net %3$.2f) seconds."
-; Maybe not this
 COM_SCHEDULER_SCHEDULER_TASK_UNLOCKED="Task#%1$02d was unlocked."
-COM_SCHEDULER_SELECT_EXEC_RULE="- Select Rule -"
-COM_SCHEDULER_SELECT_INTERVAL_DAYS="- Select Interval in Days -"
-COM_SCHEDULER_SELECT_INTERVAL_HOURS="- Select Interval in Hours -"
 COM_SCHEDULER_SELECT_INTERVAL_MINUTES="- Select Interval in Minutes -"
-COM_SCHEDULER_SELECT_INTERVAL_MONTHS="- Select Interval in Months -"
 COM_SCHEDULER_SELECT_TASK_TYPE="Select task, %s"
 COM_SCHEDULER_SELECT_TYPE="- Task Type -"
 COM_SCHEDULER_TABLE_CAPTION="Tasks List"
@@ -139,12 +132,8 @@ COM_SCHEDULER_TEST_RUN_STATUS_TERMINATED="Status: Terminated"
 COM_SCHEDULER_TEST_RUN_TASK="Task: \"%s\""
 COM_SCHEDULER_TEST_RUN_TITLE="Test task (ID: %d)"
 COM_SCHEDULER_TEST_TASK="Test Task"
-COM_SCHEDULER_TRIGGER_CRON="Cron"
-COM_SCHEDULER_TRIGGER_PSEUDOCRON="Pseudocron"
-COM_SCHEDULER_TRIGGER_XVISITS="X-Visits"
 COM_SCHEDULER_TOOLBAR_UNLOCK="Unlock"
 COM_SCHEDULER_TYPE_CHOOSE="Select a Task type"
-COM_SCHEDULER_TYPE_OR_SELECT_OPTIONS="Type or select options"
 COM_SCHEDULER_WARNING_EXISTING_TASK_TYPE_NOT_FOUND="The task routine for this task could not be found!<br>It's likely that the provider plugin was removed or disabled."
 COM_SCHEDULER_XML_DESCRIPTION="Component for managing scheduled tasks and cronjobs (if supported by the server)."
 JLIB_HTML_PUBLISH_ITEM="Enable task"
@tecpromotion tecpromotion added this to the 4.1.0.v1 milestone Jan 5, 2022
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Jan 5, 2022
@tecpromotion
Copy link
Member

fixed with PR #2166

zero-24 added a commit that referenced this issue Jan 15, 2022
* add new files and new strings

* fix #2157

* fix #2160

* fix #2158

* fix #2159

* fix #2161

* fix #2170

add two new strings

* fix #2171

* fix #2172

* fix #2173

* add translation plg_task_checkfiles

* add translation plg_task_demotask

* translation part 1

* fix #2179

* fix #2175

* fix #2196

* fix #2195

* just happy new year head

* translation plg_system_schedulerunner

* translation plg_system_tasknotification

* translation plg_task_requests

* language style

* translation plg_task_sitestatus

* translation plg_actionlog_joomla

* sounds better

* sounds nicer

* Update administrator/language/de-DE/plg_system_tasknotification.ini

thanks @zero-24

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* fix output

* language style

* fix #2220

* add new strings #2222

* fix #2222

* Update administrator/language/de-DE/com_scheduler.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants