Version 6.0.0 release #721
Replies: 11 comments 12 replies
-
Sounds like a good workflow to me :) |
Beta Was this translation helpful? Give feedback.
-
|
This project has just used Github release notes up till now, is there a reason we cannot simply document the changes there this time too? Why switch to a CHANGELOG in the repo after all this time? |
Beta Was this translation helpful? Give feedback.
-
|
Got it. Are the commit messages identical on both branches for the most part? |
Beta Was this translation helpful? Give feedback.
-
|
For individual commits, mostly yes. They're cherry-picked, refactored as necessary, then merged. For the overall history, no, that won't match. Not everything gets backported (because we want to keep breaking changes out of v5), and those that are aren't necessarily all applied in the same order. There's also the odd one that is specific to the 5.x.x branch only. |
Beta Was this translation helpful? Give feedback.
-
|
@dafeder is this still something you're working on? Is there a way I can help? |
Beta Was this translation helpful? Give feedback.
-
|
I'll come back to it this week I didn't get very far yet. Where would it make sense to work on it? |
Beta Was this translation helpful? Give feedback.
-
|
I would say this discussion is a very good place to get started (I'm a fan of keep stuff in the same places instead of scattered over the web). Unless you have a different place which would make sense? |
Beta Was this translation helpful? Give feedback.
-
|
Did my best to review the three PRs mentioned here. |
Beta Was this translation helpful? Give feedback.
-
|
Does this release actually introduce draft-06 support? I didn't think so but I saw a reference to it in another thread. |
Beta Was this translation helpful? Give feedback.
-
|
It's my understanding that v5 has draft-04 support and v6 draft-06.. But maybe that's outdated wrong info in my head :) |
Beta Was this translation helpful? Give feedback.
-
|
@Seldaek Your recollection is correct. V5 is draft-03 & draft-04, and V6 adds support for draft-06. They're a bit mixed in though - so you can feed it a frankenschema that combines versions and have it work (provided you have schema validation turned off; if you turn it on then it'll validate the schema against the correct version of the spec meta-schema first and fail anything that doesn't comply). |
Beta Was this translation helpful? Give feedback.
-
|
Ok that is great news, it's a bit unclear from the commit history. So looking ahead draft-07 is a lighter lift than I thought. |
Beta Was this translation helpful? Give feedback.
-
|
I took the liberty to start sharing some data points in an effort to complete the changelog . Perhaps I'm doing duplicate work and @dafeder has already passed this step, but that's my risk. It seems like from below lists we have all the info needed to make a decent changelog and filter out duplicates from the Common baseBased on running Commits on
|
Beta Was this translation helpful? Give feedback.
-
|
From the commits on master since the common base I've derived the below changelog. The only think left to do is remove the backports from version Changelog[6.0.0] - 2024-XX-XXAdded
Changed
Deprecated
Removed
Fixed
|
Beta Was this translation helpful? Give feedback.
-
|
Removing the backports we are left with: Changelog[6.0.0] - 2024-XX-XXAdded
Changed
Deprecated
Removed
Fixed
|
Beta Was this translation helpful? Give feedback.
-
|
Beta release is out 🥳 Next step is doing some smoke testing / create draft PR for mayor application/libraries using this library. |
Beta Was this translation helpful? Give feedback.
-
|
@DannyvdSluijs thanks for doing this, I apologize I was not able to get far with this, I got very sidetracked with my main project and some other things and was honestly a little overwhelmed since the list was so long and I was so unfamiliar with most of the issues. I will do some testing with the beta release on DKAN and report any issues I see. |
Beta Was this translation helpful? Give feedback.
-
|
Initial smoke testing has gone somewhat okay. During the PR for Composer we learned that In general, I would opt to move forward with the |
Beta Was this translation helpful? Give feedback.
-
|
Don't sweat it too much, worst case Composer will remain on 5.x for now, it works and our requirements for json schema validation do not change often so I am not too worried about having to upgrade. |
Beta Was this translation helpful? Give feedback.
-
|
Version |
Beta Was this translation helpful? Give feedback.
-
I believe this project to be very close to the version 6.0.0 release. A couple of things could/should be done before we can make it so. Let's use this place to discuss and see how to move forward.
Some things that are at the top of my head are:
CHANGELOG.mdas outlined per https://keepachangelog.com/en/1.1.0/. Perhaps the compare from GitHub betweenv5.2.13andmastercan provide some insightsPHPInsights: PHPInsight isn't depending onjson-schemabut was having a leftoverrequire, see #6886.0.0-betawhich can help with the suggested smoke testingBased on the permissions granted to me by @Seldaek I should be able to manage the release process. I'm mostly curious about the thoughts and opinions of others. So also pinging @dafeder and @paul-m.
Beta Was this translation helpful? Give feedback.
All reactions