-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove B for irwsva.build #18
Open
yufree
wants to merge
66
commits into
jtleek:master
Choose a base branch
from
yufree:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@59266 bc3139a8-67e5-0310-9ffc-ced21a209358
…) added man files for ComBat git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@59673 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@59716 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@59717 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@59920 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@59924 bc3139a8-67e5-0310-9ffc-ced21a209358
…n of setting num.sv method in sva. Fixed a bug in Combat so only an intercept term can be included git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@60980 bc3139a8-67e5-0310-9ffc-ced21a209358
…o use method leek git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@61130 bc3139a8-67e5-0310-9ffc-ced21a209358
…the list, updated fsva to include the new fast method as well as the original method git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@63723 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@64678 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@64680 bc3139a8-67e5-0310-9ffc-ced21a209358
…rom being built. removed bug in fsva where svs where being normalized incorrectly for the exact case. git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@65411 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@69763 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@70050 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@70052 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@75263 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@75270 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@81642 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@81644 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@82688 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@87035 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@88838 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@88840 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91009 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit. Commit information: Commit id: c39bfae Commit message: fixed sva docs bug Committed by: jtleek Author Name: jtleek Commit date: 2014-06-04 23:53:35 -0400 Author date: 2014-06-04 23:53:35 -0400 git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91011 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 2 commits. Commit information: Commit id: 055e3a6 Commit message: Merge branch 'master' of https://github.com/jtleek/sva-devel Committed by: jtleek Author Name: jtleek Commit date: 2014-06-13 10:41:07 -0400 Author date: 2014-06-13 10:41:07 -0400 Commit id: 5d03933 Commit message: added psva, fixed imports Committed by: jtleek Author Name: jtleek Commit date: 2014-06-13 10:40:56 -0400 Author date: 2014-06-13 10:40:56 -0400 git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91370 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit. Commit information: Commit id: 21bdbce Commit message: removed dependency on fast.svd and added ability to change constant in svaseq Committed by: jtleek Author Name: jtleek Commit date: 2014-06-23 14:46:34 -0400 Author date: 2014-06-23 14:46:34 -0400 git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91757 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit. Commit information: Commit id: f88184b Commit message: updated vignette Committed by: jtleek Author Name: jtleek Commit date: 2014-06-24 13:14:49 -0400 Author date: 2014-06-24 13:14:49 -0400 git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91805 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit. Commit information: Commit id: fc897f2 added sva.check function Committed by: jtleek Author Name: jtleek Commit date: 2014-09-03 21:05:49 -0400 Author date: 2014-09-03 21:05:49 -0400 git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@93788 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit. Commit information: Commit id: fa99307 fixed documentation of sva.check Committed by: jtleek Author Name: jtleek Commit date: 2014-10-01 21:26:11 -0400 Author date: 2014-10-01 21:26:11 -0400 git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@94833 bc3139a8-67e5-0310-9ffc-ced21a209358
Commit id: a7cb4b2 Merge pull request jtleek#5 from wevanjohnson/master Added unit tests for ComBat Commit id: 7632f0c Made the following changes: 1) added unit tests for ComBat to check ComBat errors for confounded designs and for the output on simulated and the bladder cancer data. 2) Streamlined some of the ComBat errors (just shortened the text). 3) Added myself as a maintainer of the package since I am the only one updating/maintaining the ComBat part of the package. git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@100106 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@102591 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@102594 bc3139a8-67e5-0310-9ffc-ced21a209358
Commit id: 7fb36db Merge pull request jtleek#7 from wevanjohnson/master Added a mean.only option to ComBat Commit id: 29446f0 Added a mean.only option to ComBat to only adjust the mean of the batch effect (default adjusts mean and variance) Commit id: f677116 Added a mean.only option to ComBat to only adjust the mean of the batch effect (default adjusts mean and varianceA) Commit id: 6d5ae07 Merge pull request jtleek#1 from jtleek/master Brought in changes from jtleek to update my fork git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@107119 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@109589 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@109592 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@117079 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@117081 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@122710 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@122712 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@129126 bc3139a8-67e5-0310-9ffc-ced21a209358
git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@129129 bc3139a8-67e5-0310-9ffc-ced21a209358
Fixed the bug from a month ago
From: Leonardo Collado Torres <lcollado@jhsph.edu> git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@130117 bc3139a8-67e5-0310-9ffc-ced21a209358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Prof. Leek ( @jtleek ) ,
I am working on a metabolomics project and read your excellent papers on SVA. I think SVA could be applied to metabolomics studies to remove batch effects.
I found parameter B in both
num.sv
andirwsva.build
function. They are different (one for permutation and one for iteratively re-weighted) while the same name might make others confusion insva
function.Then I found B in
irwsva.build
could be substituted by awhile
loop. I constructed another weighted matrix for the mod by:Then I use a while loop based on this matrix to test if some surrogate variables are still there. If the numbers is other than 0, the reweighting process will keep running.
By this way, the iteratively re-weighted feature could be retained and use less parameters for users.
I wonder if this method could be merged into the devel version of SVA?
Thanks and Sincerely,
Miao