Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove B for irwsva.build #18

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

remove B for irwsva.build #18

wants to merge 66 commits into from

Conversation

yufree
Copy link

@yufree yufree commented Jan 9, 2017

Dear Prof. Leek ( @jtleek ) ,

I am working on a metabolomics project and read your excellent papers on SVA. I think SVA could be applied to metabolomics studies to remove batch effects.

I found parameter B in both num.sv and irwsva.build function. They are different (one for permutation and one for iteratively re-weighted) while the same name might make others confusion in sva function.

Then I found B in irwsva.build could be substituted by a while loop. I constructed another weighted matrix for the mod by:

dats2 <- dat*pprob.b*(1-pprob.gam)
dats2 <- dats2 - rowMeans(dats2)

Then I use a while loop based on this matrix to test if some surrogate variables are still there. If the numbers is other than 0, the reweighting process will keep running.

while(num.sv(dats2,mod,method="be") != 0)

By this way, the iteratively re-weighted feature could be retained and use less parameters for users.

I wonder if this method could be merged into the devel version of SVA?

Thanks and Sincerely,

Miao

m.carlson and others added 30 commits October 15, 2011 00:36
…n of setting num.sv method in sva. Fixed a bug in Combat so only an intercept term can be included

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@60980 bc3139a8-67e5-0310-9ffc-ced21a209358
…the list, updated fsva to include the new fast method as well as the original method

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@63723 bc3139a8-67e5-0310-9ffc-ced21a209358
…rom being built. removed bug in fsva where svs where being normalized incorrectly for the exact case.

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@65411 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit.

Commit information:

Commit id: c39bfae
Commit message: fixed sva docs bug
Committed by: jtleek
Author Name: jtleek
Commit date: 2014-06-04 23:53:35 -0400
Author date: 2014-06-04 23:53:35 -0400



git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91011 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 2 commits.

Commit information:

Commit id: 055e3a6
Commit message: Merge branch 'master' of https://github.com/jtleek/sva-devel
Committed by: jtleek
Author Name: jtleek
Commit date: 2014-06-13 10:41:07 -0400
Author date: 2014-06-13 10:41:07 -0400

Commit id: 5d03933
Commit message: added psva, fixed imports
Committed by: jtleek
Author Name: jtleek
Commit date: 2014-06-13 10:40:56 -0400
Author date: 2014-06-13 10:40:56 -0400



git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91370 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit.

Commit information:

Commit id: 21bdbce
Commit message: removed dependency on fast.svd and added ability to change constant in svaseq
Committed by: jtleek
Author Name: jtleek
Commit date: 2014-06-23 14:46:34 -0400
Author date: 2014-06-23 14:46:34 -0400



git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91757 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit.

Commit information:

Commit id: f88184b
Commit message: updated vignette
Committed by: jtleek
Author Name: jtleek
Commit date: 2014-06-24 13:14:49 -0400
Author date: 2014-06-24 13:14:49 -0400



git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@91805 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit.

Commit information:

Commit id: fc897f2

    added sva.check function

Committed by: jtleek
Author Name: jtleek
Commit date: 2014-09-03 21:05:49 -0400
Author date: 2014-09-03 21:05:49 -0400


git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@93788 bc3139a8-67e5-0310-9ffc-ced21a209358
Consists of 1 commit.

Commit information:

Commit id: fa99307

    fixed documentation of sva.check

Committed by: jtleek
Author Name: jtleek
Commit date: 2014-10-01 21:26:11 -0400
Author date: 2014-10-01 21:26:11 -0400


git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@94833 bc3139a8-67e5-0310-9ffc-ced21a209358
j.leek and others added 29 commits March 3, 2015 13:43
Commit id: a7cb4b2

    Merge pull request jtleek#5 from wevanjohnson/master

    Added unit tests for ComBat

Commit id: 7632f0c

    Made the following changes: 1) added unit tests for ComBat to check ComBat errors for confounded designs and for the output on simulated and the bladder cancer data. 2) Streamlined some of the ComBat errors (just shortened the text). 3) Added myself as a maintainer of the package since I am the only one updating/maintaining the ComBat part of the package.



git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@100106 bc3139a8-67e5-0310-9ffc-ced21a209358
Commit id: 7fb36db

    Merge pull request jtleek#7 from wevanjohnson/master

    Added a mean.only option to ComBat

Commit id: 29446f0

    Added a mean.only option to ComBat to only adjust the mean of the batch effect (default adjusts mean and variance)


Commit id: f677116

    Added a mean.only option to ComBat to only adjust the mean of the batch effect (default adjusts mean and varianceA)


Commit id: 6d5ae07

    Merge pull request jtleek#1 from jtleek/master

    Brought in changes from jtleek to update my fork


git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@107119 bc3139a8-67e5-0310-9ffc-ced21a209358
Merge remote-tracking branch 'upstream/master'

# Conflicts:
#	NAMESPACE
#	R/helper.R
#	R/irwsva.build.R
#	R/sva.R
From: Leonardo Collado Torres <lcollado@jhsph.edu>

git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@130117 bc3139a8-67e5-0310-9ffc-ced21a209358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants