-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payments): [Payment links] Add config for changing button text for payment links #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Dec 17, 2024
cookieg13
changed the title
add payment link support for SdkHandleConfirmPayment confirm
feat(payments): [Payment links] Add support for SdkHandleConfirmPayment
Dec 17, 2024
cookieg13
force-pushed
the
sdkConfirmBtn
branch
4 times, most recently
from
December 18, 2024 08:08
477570e
to
ecdf862
Compare
cookieg13
changed the title
feat(payments): [Payment links] Add support for SdkHandleConfirmPayment
feat(payments): [Payment links] Add config for changing button text for payment links
Dec 18, 2024
kashif-m
previously approved these changes
Dec 18, 2024
SanchithHegde
previously approved these changes
Dec 18, 2024
sahkal
previously approved these changes
Dec 18, 2024
cookieg13
dismissed stale reviews from sahkal, SanchithHegde, and kashif-m
via
December 18, 2024 10:42
eb900da
cookieg13
force-pushed
the
sdkConfirmBtn
branch
from
December 18, 2024 10:42
47a2313
to
eb900da
Compare
kashif-m
approved these changes
Dec 18, 2024
sahkal
approved these changes
Dec 18, 2024
SanchithHegde
approved these changes
Dec 18, 2024
pixincreate
added a commit
that referenced
this pull request
Dec 20, 2024
…ete-pm * 'main' of github.com:juspay/hyperswitch: refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats (#6853) refactor(customers_v2): include minor fixes for customer v2 flows (#6876) fix: cypress reports generation (#6894) fix(connector): Paypal BankRedirects (Ideal/EPS) (#6864) chore(version): 2024.12.19.1 fix(connector): [UNIFIED_AUTHENTICATION_SERVICE] change url path to `pre_authentication_processing` in pre-auth flow (#6885) refactor(users): move roles schema to global interface (#6862) feat(payment_methods): add support to pass apple pay recurring details to obtain apple pay merchant token (#6770) feat(payments): [Payment links] Add config for changing button text for payment links (#6860) feat(core): added customer phone_number and email to session token response for click to pay (#6863) FEAT(klarna): Klarna Kustom Checkout Integration (#6839) feat(users): handle email url for users in different tenancies (#6809) chore(version): 2024.12.19.0 refactor(dynamic_routing): update the authentication for update config to include JWT type (#6785) chore(env): remove unified_authentication_service base_url from integ, sandbox and production toml (#6865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added config for changing text of confirm button for payment links
Additional Changes
Motivation and Context
How did you test it?
1. Update `allowed_domains` in business profile (Expand to see details)
2. Create a payment link with `payment_button_text` (Expand to see details)
Response of /payments
{ "payment_id": "pay_uWGKvq0GhsPOLazRZCaj", "merchant_id": "merchant_1734440294", "status": "requires_payment_method", "amount": 100, "net_amount": 100, "shipping_cost": null, "amount_capturable": 100, "amount_received": null, "connector": null, "client_secret": "pay_uWGKvq0GhsPOLazRZCaj_secret_33a1Sy4E5rs7Tv53I4Is", "created": "2024-12-18T08:00:55.515Z", "currency": "EUR", "customer_id": null, "customer": null, "description": null, "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": null, "payment_method": null, "payment_method_data": null, "payment_token": null, "shipping": null, "billing": null, "order_details": null, "email": null, "name": null, "phone": null, "return_url": "http://127.0.0.1:5500/src/pl_iframe.html", "authentication_type": null, "statement_descriptor_name": null, "statement_descriptor_suffix": null, "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": null, "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": null, "manual_retry_allowed": null, "connector_transaction_id": null, "frm_message": null, "metadata": null, "connector_metadata": null, "feature_metadata": null, "reference_id": null, "payment_link": { "link": "http://localhost:8080/payment_link/merchant_1734440294/pay_uWGKvq0GhsPOLazRZCaj?locale=zh-Hant", "secure_link": "http://localhost:8080/payment_link/s/merchant_1734440294/pay_uWGKvq0GhsPOLazRZCaj?locale=zh-Hant", "payment_link_id": "plink_ETWyoDZsOyC4f68LRjdS" }, "profile_id": "pro_DD9djS7uH6B6uB9A8Nl4", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": null, "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2024-12-29T21:47:35.508Z", "fingerprint": null, "browser_info": null, "payment_method_id": null, "payment_method_status": null, "updated": "2024-12-18T08:00:55.532Z", "split_payments": null, "frm_metadata": null, "merchant_order_reference_id": null, "order_tax_amount": null, "connector_mandate_id": null }
3. Set `payment_button_text` in business profile config
cURL
4. Screenshots (Expand to see details)
Open the secure payment link (`secure_link` in API response) in an iframe for validating the functionality. For checking payment_link simply click on the payment_link (`payment_link` in API response)Screenshot for payment link
Screenshot for secured payment link
Checklist
cargo +nightly fmt --all
cargo clippy