refactor(customers_v2): include minor fixes for customer v2 flows #6876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of fully qualifying it
…erate_delete_customer_response()` method
…mIntentResponse` and `PaymentsRetrieveResponse`
SanchithHegde
added
A-core
|
Review changes with Changed Files
|
hyperswitch-bot
bot
added
M-api-contract-changes
SanchithHegde
force-pushed
the
customers-v2-minor-fixes
branch
from
e0d42d6 to
5d022cf
Compare
tsdk02
approved these changes
Dec 18, 2024
SanchithHegde
added
the
S-waiting-on-review
Sarthak1799
approved these changes
Dec 18, 2024
Chethan-rao
approved these changes
Dec 18, 2024
Narayanbhat166
approved these changes
Dec 18, 2024
SanchithHegde
removed
the
S-waiting-on-review
pixincreate
added a commit
that referenced
this pull request
Dec 20, 2024
…ete-pm * 'main' of github.com:juspay/hyperswitch: refactor(dynamic_routing): add col payment_method_type in dynamic_routing_stats (#6853) refactor(customers_v2): include minor fixes for customer v2 flows (#6876) fix: cypress reports generation (#6894) fix(connector): Paypal BankRedirects (Ideal/EPS) (#6864) chore(version): 2024.12.19.1 fix(connector): [UNIFIED_AUTHENTICATION_SERVICE] change url path to `pre_authentication_processing` in pre-auth flow (#6885) refactor(users): move roles schema to global interface (#6862) feat(payment_methods): add support to pass apple pay recurring details to obtain apple pay merchant token (#6770) feat(payments): [Payment links] Add config for changing button text for payment links (#6860) feat(core): added customer phone_number and email to session token response for click to pay (#6863) FEAT(klarna): Klarna Kustom Checkout Integration (#6839) feat(users): handle email url for users in different tenancies (#6809) chore(version): 2024.12.19.0 refactor(dynamic_routing): update the authentication for update config to include JWT type (#6785) chore(env): remove unified_authentication_service base_url from integ, sandbox and production toml (#6865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR includes minor fixes suggested in my previous PR #6836. This PR includes the following changes:
CustomerUpdateRequestInternalinstead of fully qualifying it.fetch_domain_model_and_update_and_generate_delete_customer_response()method toredact_customer_details_and_generate_response().customer_idfield inPaymentsConfirmIntentResponseandPaymentsRetrieveResponseAPI models.Additional Changes
This PR adds the
customer_idfield in thePaymentsConfirmIntentResponseandPaymentsRetrieveResponseAPI models. This does not affect any API contract for v1 APIs.Motivation and Context
Addresses minor fixes in customers v2 APIs.
How did you test it?
For the
customer_idfield in being included inPaymentsConfirmIntentResponseandPaymentsRetrieveResponseAPI models, I tried out the payment confirm intent v2 and payment intent retrieve v2 endpoint and confirmed that thecustomer_idfield is being included and populated correctly.Checklist
cargo +nightly fmt --allcargo clippy