Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cypress): make amount configurable #7219

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented Feb 7, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

this pr makes the amount for refund and capture configurable within connector configs.
standardizes the amount to be 6000 while making partial amount to be 2000.
while doing so, a lot of config clean up has been done.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

below mentioned prs are closed on behalf of this since the implementation done there is subpar, unmanageable and has a lot of conflicts:

#6286
#6223
#6292

How did you test it?

Adyen Cybersource Stripe
image image image

since the changes made are same to every other connector, and given that they all have same behavior, i've only added screenshots of 3 connectors.

Checklist

  • I formatted the code npm run format
  • I addressed lints thrown by npm run lint
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

…unt-configurable

* 'main' of github.com:juspay/hyperswitch: (37 commits)
  refactor(router): add display_name field to connector feature api  (#7121)
  ci(cypress): Add Tests for Customer Deletion and Psync flows (#7158)
  feat(connector): [DataTrans] ADD 3DS Flow (#6026)
  chore(version): 2025.02.07.0
  chore(connectors): [fiuu] update pm_filters for apple pay and google pay (#7182)
  feat(router): add `organization_id` in authentication table and add it in authentication events (#7168)
  fix(dashboard_metadata): mask `poc_email` and `data_value` for DashboardMetadata (#7130)
  feat(core): Add support for v2 payments get intent using merchant reference id (#7123)
  refactor(customer): return redacted customer instead of error (#7122)
  fix(connector): handle unexpected error response from bluesnap connector (#7120)
  feat(routing): Contract based routing integration  (#6761)
  refactor(dynamic_fields): dynamic fields for Adyen and Stripe, renaming klarnaCheckout, WASM for KlarnaCheckout (#7015)
  feat(connector): [COINGATE] Add Template PR  (#7052)
  chore(roles): remove redundant variant from PermissionGroup (#6985)
  refactor(router): store `network_transaction_id` for `off_session` payments irrespective of the `is_connector_agnostic_mit_enabled` config (#7083)
  chore(connector): [Fiuu] log keys in the PSync response (#7189)
  ci(cypress): fix nmi and paypal (#7173)
  chore(version): 2025.02.06.0
  chore(postman): update Postman collection files
  feat(connector): [Deutschebank] Add Access Token Error struct (#7127)
  ...
@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Feb 7, 2025
@pixincreate pixincreate added this to the February 2025 Release milestone Feb 7, 2025
@pixincreate pixincreate self-assigned this Feb 7, 2025
@pixincreate pixincreate requested a review from a team as a code owner February 7, 2025 12:56
Copy link

semanticdiff-com bot commented Feb 7, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/commands.js  89% smaller
  cypress-tests/cypress/e2e/spec/Payment/00022-Variations.cy.js  49% smaller
  cypress-tests/cypress/e2e/configs/Payment/Commons.js  27% smaller
  cypress-tests/cypress/e2e/spec/Payment/00006-NoThreeDSManualCapture.cy.js  19% smaller
  cypress-tests/cypress/e2e/spec/Payment/00016-ThreeDSManualCapture.cy.js  19% smaller
  cypress-tests/cypress/e2e/spec/Payment/00014-SaveCardFlow.cy.js  18% smaller
  cypress-tests/cypress/e2e/spec/Payment/00010-SyncRefund.cy.js  17% smaller
  cypress-tests/cypress/e2e/spec/Payment/00026-DeletedCustomerPsyncFlow.cy.js  17% smaller
  cypress-tests/cypress/e2e/spec/Payment/00029-IncrementalAuth.cy.js  17% smaller
  cypress-tests/cypress/e2e/configs/Payment/WorldPay.js  14% smaller
  cypress-tests/cypress/e2e/spec/Payment/00009-RefundPayment.cy.js  13% smaller
  cypress-tests/cypress/e2e/configs/Payment/Datatrans.js  7% smaller
  cypress-tests/cypress/e2e/configs/Payment/Fiservemea.js  7% smaller
  cypress-tests/cypress/e2e/configs/Payment/WellsFargo.js  7% smaller
  cypress-tests/cypress/e2e/configs/Payment/Novalnet.js  7% smaller
  cypress-tests/cypress/e2e/configs/Payment/Deutschebank.js  7% smaller
  cypress-tests/cypress/e2e/configs/Payment/Jpmorgan.js  7% smaller
  cypress-tests/cypress/e2e/configs/Payment/Fiuu.js  6% smaller
  cypress-tests/cypress/e2e/configs/Payment/Elavon.js  5% smaller
  cypress-tests/cypress/e2e/configs/Payment/Paybox.js  5% smaller
  cypress-tests/cypress/e2e/configs/Payment/Checkout.js  4% smaller
  cypress-tests/cypress/e2e/configs/Payment/Nmi.js  4% smaller
  cypress-tests/cypress/e2e/configs/Payment/Noon.js  4% smaller
  cypress-tests/cypress/e2e/configs/Payment/Paypal.js  4% smaller
  cypress-tests/cypress/e2e/configs/Payment/Stripe.js  3% smaller
  cypress-tests/cypress/e2e/configs/Payment/BankOfAmerica.js  2% smaller
  cypress-tests/cypress/e2e/configs/Payment/Bluesnap.js  2% smaller
  cypress-tests/cypress/e2e/configs/Payment/Nexixpay.js  1% smaller
  cypress-tests/cypress/e2e/configs/Payment/Cybersource.js  1% smaller
  cypress-tests/cypress/e2e/configs/Payment/Adyen.js  0% smaller
  cypress-tests/cypress/e2e/configs/Payment/Iatapay.js  0% smaller
  cypress-tests/cypress/e2e/configs/Payment/Trustpay.js  0% smaller
  cypress-tests/cypress/e2e/configs/Payment/Xendit.js  0% smaller
  cypress-tests/cypress/e2e/configs/PaymentMethodList/Commons.js  0% smaller
  cypress-tests/cypress/e2e/configs/Routing/Adyen.js  0% smaller
  cypress-tests/cypress/e2e/configs/Routing/Stripe.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00011-CreateSingleuseMandate.cy.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00012-CreateMultiuseMandate.cy.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00013-ListAndRevokeMandate.cy.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00015-ZeroAuthMandate.cy.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00019-MandatesUsingPMID.cy.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00020-MandatesUsingNTIDProxy.cy.js  0% smaller
  cypress-tests/cypress/e2e/spec/Payment/00021-UPI.cy.js  0% smaller
  cypress-tests/cypress/fixtures/create-confirm-body.json  0% smaller
  cypress-tests/cypress/fixtures/create-mandate-cit.json  0% smaller
  cypress-tests/cypress/fixtures/create-payment-body.json  0% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant