Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dynamodb scaler documentation #680

Merged
merged 30 commits into from
Mar 22, 2022

Conversation

samueleresca
Copy link
Contributor

@samueleresca samueleresca commented Feb 24, 2022

Documentation regarding the AWS DynamoDB scaler: kedacore/keda#2486

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#2482

@netlify
Copy link

netlify bot commented Feb 24, 2022

❌ Deploy Preview for keda failed.

🔨 Explore the source changes: 526d462

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/6233b317bf6bd30009ff3425

chalin and others added 2 commits February 25, 2022 09:11
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
@samueleresca samueleresca force-pushed the adding-dynamodb-scaler-doc branch from 1a62143 to c92fe21 Compare February 25, 2022 09:11
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first rough review but things look good AFAIK, apart from a few topics

content/docs/2.6/scalers/aws-dynamodb.md Outdated Show resolved Hide resolved
content/docs/2.6/scalers/aws-dynamodb.md Outdated Show resolved Hide resolved
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
@samueleresca samueleresca requested a review from JorTurFer as a code owner March 11, 2022 19:28
@tomkerkhove
Copy link
Member

LGTM, merging once conflicts are fixed and feature PR is merged.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only small nit

content/docs/2.7/scalers/aws-dynamodb.md Outdated Show resolved Hide resolved
chalin and others added 9 commits March 17, 2022 22:13
…#670)

Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
luistilingue and others added 15 commits March 17, 2022 22:13
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
…re#701)

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
… Functions using the new EventHub functions extension. (kedacore#686)

Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Co-authored-by: Yarden Siboni <yasiboni@microsoft.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
* Document GCP PodIdentity for PubSub contributed by @hermanbanken

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Align v2.6

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Add missing sample

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
…ffect rate limiting (kedacore#702)

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
@samueleresca samueleresca force-pushed the adding-dynamodb-scaler-doc branch from 9acd960 to e502ae2 Compare March 17, 2022 22:14
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this! ❤️

@JorTurFer JorTurFer merged commit a056e9d into kedacore:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS DynamoDb scaler