Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cassandra Scaler #1841

Closed
wants to merge 105 commits into from
Closed

Add Cassandra Scaler #1841

wants to merge 105 commits into from

Conversation

nilayasiktoprak
Copy link
Contributor

@nilayasiktoprak nilayasiktoprak commented May 30, 2021 •
edited
Loading

Signed-off-by: nilayasiktoprak nilayasiktoprak@gmail.com

Add a new Cassandra Scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Relates to #1738

This was referenced May 30, 2021
Closed
Closed
tomkerkhove
tomkerkhove reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Would you mind adding some end-to-end tests please?

@nilayasiktoprak
Copy link
Contributor Author

Thanks for the PR! Would you mind adding some end-to-end tests please?

I will definitely add the tests once my finals week finishes! (They'll finish within 2 weeks)

@tomkerkhove
Copy link
Member

Thanks for the PR! Would you mind adding some end-to-end tests please?

I will definitely add the tests once my finals week finishes! (They'll finish within 2 weeks)

Thank you and good luck!

@tomkerkhove
Copy link
Member

Any update on this @nilayasiktoprak ?

@nilayasiktoprak
Copy link
Contributor Author

nilayasiktoprak commented Jun 21, 2021 •
edited
Loading

Any update on this @nilayasiktoprak ?

My finals have just finished and I'm currently working on the tests.

@tomkerkhove
Copy link
Member

Congrats on finishing your finals!

Just checking in if you'll have time to finish this PR @nilayasiktoprak?

@nilayasiktoprak
Copy link
Contributor Author

Congrats on finishing your finals!

Just checking in if you'll have time to finish this PR @nilayasiktoprak?

Thank you very much @tomkerkhove, I'm totally aware that my test process has been a bit slow due to some other cases. I only need to finish e2e test and I'll try my best to send it as soon as possible.
Thank you for checking up on me!

ahmelsayed
ahmelsayed reviewed Aug 5, 2021
View reviewed changes
config/manager/kustomization.yaml Outdated
@@ -1,9 +0,0 @@
resources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental remove? I think we need this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this closed pr of mine, #1817, I was told to exclude these two files from my pr so I deleted them in this pr. Should i add them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just don't include changes on this file in your PR.

ahmelsayed
ahmelsayed reviewed Aug 5, 2021
View reviewed changes
config/metrics-server/kustomization.yaml Outdated
@@ -1,14 +0,0 @@
resources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here as the other kustomization.yaml file.

nilayasiktoprak and others added 17 commits October 23, 2021 17:46
@nilayasiktoprak
Add Cassandra Scaler
5eb41d8 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Update pull request id
25f7bf7 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@Ritikaa96 @nilayasiktoprak
correcting naming and links in README (kedacore#1842)
cc771c3 
* correcting naming and links in readme
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@Ritikaa96 @nilayasiktoprak
cron: adding validation for range or hyphenated inputs for start and …
f29f780 
…end (kedacore#1836)

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@Shubham82 @nilayasiktoprak
Fix: READY and ACTIVE fields of ScaledJob to show status. (kedacore#1855
d80447e 
)

Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Fix CHANGELOG.md
68c5e7f 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Update Cassandra scaler files
7e7e8ef 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Add deleted kustomization files
6e7688e 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Update CHANGELOG.md
b44a003 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@Shubham82 @nilayasiktoprak
Show HashiCorp Vault Address when using 'kubectl get ta' or 'kubectl …
5d3d198 
…get cta' (kedacore#1862)

Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
Don't panic when HashiCorp Vault path doesn't exist (kedacore#1867)
b550036 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@amirschw @nilayasiktoprak
Support non-public cloud environments in the Azure Storage Queue and …
c6fb478 
…Azure Storage Blob scalers (kedacore#1863)

Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@renovate @renovate-bot
@tomkerkhove @nilayasiktoprak
Configure Renovate (kedacore#1824)
40e1ed2 
* Add renovate.json

* Provide additional configuration for Renovate (kedacore#1854)

* chore: Renovate configuration for single PR (kedacore#1871)

* Use single PR for all dependency updates

Signed-off-by: GitHub <noreply@github.com>

* Use package filters

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@tomkerkhove @nilayasiktoprak
docs: Add container image scanning in security policy (kedacore#1882)
a442bc6 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@Dorn- @nilayasiktoprak
feat: adding version metadata to be able to specify kafka broker vers…
31c38fa 
…ion (kedacore#1866)

Signed-off-by: Flavien Chantelot <contact@flavien.dev>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@amirschw @nilayasiktoprak
Extend Azure Monitor scaler to support custom metrics (kedacore#1883)
61571c2 
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
Update Renovate to describe updates in the commmit (kedacore#1886)
5a4e5ee 
This should append a table in the commit message body describing all updates in the commit.

Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Jorge Turrado Ferrero and others added 21 commits October 23, 2021 17:56
@zroubalik @nilayasiktoprak
Add support to get connection data from Trigger Authorization in MySQ…
9b16547 
…L Scaler (kedacore#2113)


Signed-off-by: jorturfer <jorge_turrado@hotmail.es>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
Add support to get connection data from Trigger Authorization in Mong…
0d87c97 
…oDB Scaler (kedacore#2115)

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
Add support to get connection data from Trigger Authorization in Post…
f3dbefa 
…greSQL Scaler (kedacore#2114)

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Fix mongdb e2e tests (kedacore#2140)
f49d84d 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@mihaitodor @nilayasiktoprak
Add Makefile mockgen targets (kedacore#2137)
647c809 
Signed-off-by: Mihai Todor <todormihai@gmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Fix typo in Makefile (kedacore#2154)
7e2683c 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Add pageSize (using regex) in RabbitMQ Scaler (kedacore#2162)
b325d7b 
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@Ritikaa96 @zroubalik @nilayasiktoprak
Artemis Scaler parses out broker config parameters in case `restAPITe…
cb6cfea 
…mplate` is given (kedacore#2104)

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@dtsioumas @nilayasiktoprak
Add unsafeSsl parameter on InfluxDB (kedacore#2157)
c3715f5 
Signed-off-by: Dimitris Tsioumas <dtsioumas@protonmail.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
bump Golang to 1.16.9 (kedacore#2186)
3b1948d 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
bump deps (kedacore#2185)
9f35a34 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
update liiklus protobuf generation (kedacore#2184)
a15e44b 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
Prometheus scaler: omit serverAddress from generated metric name (k…
24e3e62 
…edacore#2099)

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Improve metric name creation to be unique using scaler index inside t…
1ce3d88 
…he scaler (kedacore#2161)

Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@Ritikaa96 @zroubalik @nilayasiktoprak
Provide support for configuring authentication through TriggerAuthent…
5cc3969 
…ication for Stan scaler (kedacore#2167)

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@zroubalik @nilayasiktoprak
MySQL Scaler: don't expose connection string in metricName (kedacor…
c5021f9 
…e#2171)

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@tomkerkhove @nilayasiktoprak
chore: Provide configuration for automatically closing inactive issues (
744c3c7 
kedacore#2189)

Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@tomkerkhove @nilayasiktoprak
chore: Change feature as allowed label for stale issues, instead of…
694277d 
… `feature-request` (kedacore#2193)

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@tomkerkhove @nilayasiktoprak
docs: Add step in release process for next release (kedacore#2205)
19b4f03 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Update .gitignore
a073d6a 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Update cassandra files
4671de2 
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
@nilayasiktoprak
Copy link
Contributor Author

Beacuse I forgot to sign off my commits, I had to do rebase and then the commit number increased up to 105. Could you lead me what to do about this, please?

@tomkerkhove
Copy link
Member

No worries, we are here to help! You can follow this doc if you have forgotten to sign your commit - Let me know how it goes!

However, if your branch is behind with a ton of commits, it might be an alternative to create a fresh branch and we can change the PR to use that new one instead, if you prefer. That way you don't have to follow the steps above and you can simply branch of of our latest main branch.

@nilayasiktoprak
Copy link
Contributor Author

No worries, we are here to help! You can follow this doc if you have forgotten to sign your commit - Let me know how it goes!

However, if your branch is behind with a ton of commits, it might be an alternative to create a fresh branch and we can change the PR to use that new one instead, if you prefer. That way you don't have to follow the steps above and you can simply branch of of our latest main branch.

Thank you very much for your helpful explanation @tomkerkhove :) I actually followed the instructions in DCO check when it failed and then these commits increased up to 105 while I wanted to send only 5.

I guess it would be much better if we change the PR to a new branch as you suggested. So now I should create a new branch and apply my changes there and then?

@tomkerkhove
Copy link
Member

That sounds good - Then you can just close this PR and open a new one

@nilayasiktoprak
Copy link
Contributor Author

Oh, alright!

@nilayasiktoprak nilayasiktoprak deleted the cassandra_scaler branch October 28, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed left review comments

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.