Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide New Relic scaler #2286

Closed
wants to merge 1,259 commits into from
Closed

feat: Provide New Relic scaler #2286

wants to merge 1,259 commits into from

Conversation

marcelobartsch-jt
Copy link
Contributor

@marcelobartsch-jt marcelobartsch-jt commented Nov 15, 2021 •
edited
Loading

Provide New Relic scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Relates to #2290

dependabot bot and others added 30 commits April 6, 2021 10:26
@dependabot
Bump k8s.io/code-generator from 0.20.4 to 0.20.5 (#1712)
dfe31f4 
Bumps [k8s.io/code-generator](https://github.com/kubernetes/code-generator) from 0.20.4 to 0.20.5.
- [Release notes](https://github.com/kubernetes/code-generator/releases)
- [Commits](kubernetes/code-generator@v0.20.4...v0.20.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/golang/protobuf from 1.4.3 to 1.5.2 (#1716)
3677da1 
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.4.3 to 1.5.2.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.4.3...v1.5.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump k8s.io/api from 0.20.4 to 0.20.5 (#1715)
0928c7a 
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.20.4 to 0.20.5.
- [Release notes](https://github.com/kubernetes/api/releases)
- [Commits](kubernetes/api@v0.20.4...v0.20.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump k8s.io/metrics from 0.20.4 to 0.20.5 (#1718)
b90708c 
Bumps [k8s.io/metrics](https://github.com/kubernetes/metrics) from 0.20.4 to 0.20.5.
- [Release notes](https://github.com/kubernetes/metrics/releases)
- [Commits](kubernetes/metrics@v0.20.4...v0.20.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#1724)
89577e1 
Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/go-sql-driver/mysql/releases)
- [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md)
- [Commits](go-sql-driver/mysql@v1.5.0...v1.6.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/influxdata/influxdb-client-go/v2 from 2.2.2 to 2.2.3 (#…
1ebccfc 
…1725)

Bumps [github.com/influxdata/influxdb-client-go/v2](https://github.com/influxdata/influxdb-client-go) from 2.2.2 to 2.2.3.
- [Release notes](https://github.com/influxdata/influxdb-client-go/releases)
- [Changelog](https://github.com/influxdata/influxdb-client-go/blob/master/CHANGELOG.md)
- [Commits](influxdata/influxdb-client-go@v2.2.2...v2.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/prometheus/client_golang from 1.9.0 to 1.10.0 (#1726)
4cca208 
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.9.0...v1.10.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/onsi/ginkgo from 1.15.2 to 1.16.0 (#1727)
1372292 
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.15.2 to 1.16.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v1.15.2...v1.16.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump k8s.io/apiserver from 0.20.4 to 0.20.5 (#1728)
73744df 
Bumps [k8s.io/apiserver](https://github.com/kubernetes/apiserver) from 0.20.4 to 0.20.5.
- [Release notes](https://github.com/kubernetes/apiserver/releases)
- [Commits](kubernetes/apiserver@v0.20.4...v0.20.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump google.golang.org/grpc from 1.36.0 to 1.36.1 (#1719)
ac6ddb1 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.36.0 to 1.36.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.36.0...v1.36.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump google.golang.org/api from 0.42.0 to 0.43.0 (#1717)
cfa8bdf 
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.42.0 to 0.43.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.42.0...v0.43.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/tidwall/gjson from 1.6.8 to 1.7.4 (#1731)
4a67639 
Bumps [github.com/tidwall/gjson](https://github.com/tidwall/gjson) from 1.6.8 to 1.7.4.
- [Release notes](https://github.com/tidwall/gjson/releases)
- [Commits](tidwall/gjson@v1.6.8...v1.7.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump cloud.google.com/go from 0.79.0 to 0.81.0 (#1729)
8bbdec0 
Bumps [cloud.google.com/go](https://github.com/googleapis/google-cloud-go) from 0.79.0 to 0.81.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md)
- [Commits](googleapis/google-cloud-go@v0.79.0...v0.81.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.38.10 to 1.38.13 (#1730)
f51af21 
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.38.10 to 1.38.13.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.38.10...v1.38.13)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tomkerkhove
Breaking changes to GitHub's Issue Forms (#1733)
413cdc8 
* Breaking changes to feature request

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Remove issue body

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Update suggest scaler for breaking changes

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Update bug report for breaking changes

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@pdominguite
Add OpenStack Swift scaler e2e tests (#1522)
157537f 
* Add OpenStack Swift scaler e2e tests

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

Co-authored-by: Antonio Robson de Paula <robson.p@sidi.org.br>

* Add OpenStack helper class

This helper creates an HTTP client using Axios for querying a specific OpenStack project API such as Swift.

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Add OpenStack Swift helper class

This helper encapsulates the Swift API operations

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Add Axios dependency to package.json

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Add environment variables for OpenStack Swift scaler e2e tests

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Update CHANGELOG.md

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>

* Change test environment variable names

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>
@troydn
add Azure Pipelines Scaler (#1706)
6423e34
@zroubalik
Fix regression brought by using time.NewTimer() in scale loop (#1739)
80ab797 
* fix timer in scale loop

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* update changelog

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
inject OpenStack and Azure DevOps secrets (#1743)
dd75f09 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@troydn
add azure devops dependency (#1745)
b2f5206 
Signed-off-by: Troy <troydenorme@hotmail.com>
@pdominguite
Fix Swift scaler E2E test enviroment variables (#1747)
b7558c0 
Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>
@guilhem
chore: Don't send .git in docker context (#1753)
3b24725 
Signed-off-by: Guilhem Lettron <guilhem@barpilot.io>

Context is lighter when running on remote docker server
Image was not reproducible
Azure ACR build ignore .git by default
@arschles
Adding HTTP timeout to the IBM MQ Scaler (#1758)
09738a3 
* Adding HTTP timeout to the IBM MQ Scaler

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* adding to changelog

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* fixing tests

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@zroubalik
Changelog chores (#1760)
f9c47a2 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
bump deps (#1740)
b42f0e2 
* bump deps

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* bump deps

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
updating golangci and removing deprecated linters (#1763)
dae176d 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
bump hashicorp/api dependency (#1762)
851b48a 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@coderanger
👷‍♂️ Install the kubebuilder tools in the build image instead. (#1775)
3f97263 
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
@zroubalik
Helm is not needed in build tools image (#1777)
d4f6fb3 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik
hardcode os and arch in kubebuilder installer (#1778)
d49ece3
Add note about Snyk (#2351)
e1a9897 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer JorTurFer requested a review from a team November 29, 2021 07:23
JorTurFer
JorTurFer requested changes Nov 29, 2021
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! ❤️
Only small nits

pkg/scalers/newrelic_scaler_test.go Outdated Show resolved Hide resolved
pkg/scalers/newrelic_scaler.go Outdated Show resolved Hide resolved
tomkerkhove and others added 19 commits November 29, 2021 09:25
@tomkerkhove
chore: Never close Epic issues (#2358)
1313057 
Never close Epic issues with our stale bot.

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@renovate @renovate-bot
chore(deps): update actions/setup-python action to v2.3.1 (#2360)
61ef7d7 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@tomkerkhove
chore: Remove PR checkbox for Renovate PRs (#2362)
73b97f9
@zroubalik
Increse golangci timeout to 10m (#2368)
2fa5748 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
remove test code not in use
e535699 
Signed-off-by: Marcelo Bartsch <marcelo.bartsch@letgo.com>
Merge remote-tracking branch 'origin/main' into newrelic-scaler
5c20f07
@bpinske
Graphite scaler should use latest datapoint, not earliest, returned (#…
0341501 
…2365)

Signed-off-by: Brandon Pinske <brandon.pinske@crowdstrike.com>
@dependabot
Bump github.com/Azure/azure-sdk-for-go from 59.3.0+incompatible to 59…
7221d9c 
….4.0+incompatible (#2371)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/aws/aws-sdk-go from 1.42.11 to 1.42.16 (#2372)
f19aa63 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/influxdata/influxdb-client-go/v2 from 2.5.1 to 2.6.0 (#…
31e8808 
…2374)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/tidwall/gjson from 1.11.0 to 1.12.1 (#2375)
9c58ba2 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add azure-functions-core-tool v4.x link to release docs (#2369)
7591157
@solsson
Kubernetes Workload Scaler: ignore terminated pods (#2384)
82efb55 
Signed-off-by: Staffan Olsson <staffan@repos.se>
Merge branch 'kedacore:main' into newrelic-scaler
de2e494
Fix some error messages and add a check for missing threshold value
12a5c1e 
Clean up more test logs

Signed-off-by: Marcelo Bartsch <marcelo.bartsch@letgo.com>
initial e2e tests for new relic
b2468aa 
Signed-off-by: Marcelo Bartsch <marcelo.bartsch@letgo.com>
Merge branch 'newrelic-scaler' of github.com:marcelobartsch/keda into…
63e9a08 
… newrelic-scaler
remove keys
07b04e4
make account id a env variable too
7d6f919 
Signed-off-by: Marcelo Bartsch <marcelo.bartsch@letgo.com>
@marcelobartsch-jt
Copy link
Contributor Author

sorry I screwup my local repo and corrupted it, so I needed to recreate the branch will re-open the PR asap

@marcelobartsch-jt marcelobartsch-jt mentioned this pull request Dec 7, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaJackson-jobvite JoshuaJackson-jobvite JoshuaJackson-jobvite left review comments

@JorTurFer JorTurFer JorTurFer requested changes

@zroubalik zroubalik zroubalik left review comments

Assignees

@ahmelsayed ahmelsayed

@zroubalik zroubalik

@JorTurFer JorTurFer

Labels
None yet
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.