show only logs with a severity level of ERROR or higher in the stderr. #4882

Adarsh-verma-14 · 2023-08-16T08:56:58Z

Signed-off-by: Adarsh-verma-14 t_adarsh.verma@india.nec.com

In the logs of keda-metrics-apiserver, show only log messages with a severity level of ERROR or higher in the stderr and Log messages with severity levels below ERROR will be included in the stdout stream.

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4049

… stream. Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>

github-actions · 2023-08-16T08:57:11Z

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Our contribution guide

JorTurFer · 2023-08-16T13:39:36Z

/run-e2e internal
Update: You can check the progress here

JorTurFer

As this is to solve an issue, could you update the changelog as well with the reference to the issue?

JorTurFer · 2023-08-16T13:42:31Z

config/metrics-server/deployment.yaml

@@ -57,7 +57,7 @@ spec:
          args:
          - /usr/local/bin/keda-adapter
          - --secure-port=6443
-          - --logtostderr=true
+          - --stderrthreshold=ERROR


Shouldn't we add both? I mean, only printing errors, but errors should go to stderr

Agree with @JorTurFer here

Absolutely agree with @JorTurFer, if I use both arg then the output format of the logs will remain in the stderr , as the --logtostderr=true arg explicitly directs the log output to the stderr.
However, the --stderrthreshold=ERROR arg will filter the logs based on their severity levels. Only logs with a severity level of ERROR or higher will be displayed in the stderr. Logs with severity levels below ERROR will not be shown in the stderr even though they are directed to stderr.

Co-authored-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* Add testing strategy document Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add extra info to tests Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go` for the StatefulSet scaling resolver error message. Signed-off-by: David Morrison <drmorr@appliedcomputing.io>

…dacore#4909)

* Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

…ore#4900)

…Workload Identity in TriggerAuthentication (kedacore#4696) Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

* chore(deps): bump helm/kind-action from 1.7.0 to 1.8.0 Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: helm/kind-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update kind node version Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> * Update template-versions-smoke-tests.yml Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

…m `queueName` (kedacore#4940)

Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>

semgrep-app · 2023-09-04T05:22:52Z

.github/workflows/template-smoke-tests.yml

@@ -35,7 +35,7 @@ jobs:
          fetch-depth: 1

      - name: Create k8s ${{ inputs.kubernetesVersion }} Kind Cluster
-        uses: helm/kind-action@v1.7.0
+        uses: helm/kind-action@v1.8.0


An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
_{Ignore this finding from third-party-action-not-pinned-to-commit-sha.}

Adarsh-verma-14 · 2023-09-04T05:25:43Z

sorry something is wrong from my side I create again PR regarding this.

Adarsh-verma-14 · 2023-09-06T05:49:37Z

I have closed this PR and also raised a new PR(#4944 ) for the same issue .

show only logs with a severity level of ERROR or higher in the stderr…

2f06fab

… stream. Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>

Adarsh-verma-14 requested a review from a team as a code owner August 16, 2023 08:56

JorTurFer reviewed Aug 16, 2023

View reviewed changes

nitishchauhan0022 and others added 14 commits September 4, 2023 10:39

adding the script to validate changelog (kedacore#4731)

360f28a

Co-authored-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge.turrado@scrm.lidl>

Deprecation cleanup for 2.12 release (kedacore#4806)

17b964e

Update (kedacore#4904)

a50d345

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

fix typo in log message (kedacore#4902)

9f7c454

`s/deployment/statefulset` in `pkg/scaling/resolver/scaling_resolver.go` for the StatefulSet scaling resolver error message. Signed-off-by: David Morrison <drmorr@appliedcomputing.io>

chore: KEDA v2.12 is targeted for September 26th, instead of 12th (ke…

57200f9

…dacore#4909)

feat(aws-sqs): Support for scaling to include delayed messages (kedac…

1ff885e

…ore#4900)

chore: KEDA is a CNCF Graduated project (kedacore#4896)

2e70bfd

chore: Replace deprecated command with environment file (kedacore#4915)

5505016

Provide validation for identityId with Azure pod identity & Azure AD …

c7d9b8c

…Workload Identity in TriggerAuthentication (kedacore#4696) Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

Add Fix to solace endpointURL to query escape special character fro…

3637053

…m `queueName` (kedacore#4940)

show only logs with a severity level of ERROR or higher in the stderr

55b73d3

Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>

semgrep-app bot reviewed Sep 4, 2023

View reviewed changes

Adarsh-verma-14 closed this Sep 4, 2023

Adarsh-verma-14 deleted the logs-stream branch September 4, 2023 05:30

Adarsh-verma-14 mentioned this pull request Sep 6, 2023

show only logs with a severity level of ERROR or higher in the stderr #4944

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show only logs with a severity level of ERROR or higher in the stderr. #4882

show only logs with a severity level of ERROR or higher in the stderr. #4882

Adarsh-verma-14 commented Aug 16, 2023

github-actions bot commented Aug 16, 2023

JorTurFer commented Aug 16, 2023 •

edited by github-actions bot

Loading

JorTurFer left a comment •

edited

Loading

JorTurFer Aug 16, 2023 •

edited

Loading

zroubalik Aug 16, 2023

Adarsh-verma-14 Aug 17, 2023

semgrep-app bot Sep 4, 2023

Adarsh-verma-14 commented Sep 4, 2023

Adarsh-verma-14 commented Sep 6, 2023

show only logs with a severity level of ERROR or higher in the stderr. #4882

show only logs with a severity level of ERROR or higher in the stderr. #4882

Conversation

Adarsh-verma-14 commented Aug 16, 2023

Checklist

github-actions bot commented Aug 16, 2023

JorTurFer commented Aug 16, 2023 • edited by github-actions bot Loading

JorTurFer left a comment • edited Loading

Choose a reason for hiding this comment

JorTurFer Aug 16, 2023 • edited Loading

Choose a reason for hiding this comment

zroubalik Aug 16, 2023

Choose a reason for hiding this comment

Adarsh-verma-14 Aug 17, 2023

Choose a reason for hiding this comment

semgrep-app bot Sep 4, 2023

Choose a reason for hiding this comment

Adarsh-verma-14 commented Sep 4, 2023

Adarsh-verma-14 commented Sep 6, 2023

JorTurFer commented Aug 16, 2023 •

edited by github-actions bot

Loading

JorTurFer left a comment •

edited

Loading

JorTurFer Aug 16, 2023 •

edited

Loading