Auto-close About Dialog before locking databases #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoerious
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
LGTM, but in the future we should have a more generic solution. Like a flag on each modal of whether it should be auto-closed or not and then the lock function just goes ahead and closes all auto-close modals and only blocks if there are any non-auto-close modals left open.
|
I had developed one in the past but the problem is you have to handle modal choice dialogs like "Save your changes?". We need an application level setting to auto-save on lock, or similar, even just saving the encrypted data to memory and not to disk and load from memory. |
phoerious
added a commit
that referenced
this pull request
Jan 31, 2021
Added - Automatically adapt to light/dark system theme changes (Windows/macOS only) [#6034] Changed - Show window title as tooltip on system tray [#5948] - Compress Snap release as LZO for faster initial startup [#5877] - Password generator: Set maximum selectable password length to 999 [#5937] Fixed - Fix crash on app close when using SSH agent [#5935] - Fix KDF selection showing wrong item when using Argon2id [#5923] - Automatically close About dialog on database lock if it is still open [#5947] - Linux: Fix automatic launch at system startup with AppImages [#5901] - Linux: Fix click-to-move on empty area activating when using menus [#5971] - Linux: Try multiple times to show tray icon if tray is not ready yet [#5948] - macOS: Fix KeePassXC blocking clean shutdown [#6002]
aswild
added a commit
to aswild/keepassxc
that referenced
this pull request
Feb 5, 2021
Release 2.6.4 Added - Automatically adapt to light/dark system theme changes (Windows/macOS only) [keepassxreboot#6034] Changed - Show window title as tooltip on system tray [keepassxreboot#5948] - Compress Snap release as LZO for faster initial startup [keepassxreboot#5877] - Password generator: Set maximum selectable password length to 999 [keepassxreboot#5937] Fixed - Fix crash on app close when using SSH agent [keepassxreboot#5935] - Fix KDF selection showing wrong item when using Argon2id [keepassxreboot#5923] - Automatically close About dialog on database lock if it is still open [keepassxreboot#5947] - Linux: Fix automatic launch at system startup with AppImages [keepassxreboot#5901] - Linux: Fix click-to-move on empty area activating when using menus [keepassxreboot#5971] - Linux: Try multiple times to show tray icon if tray is not ready yet [keepassxreboot#5948] - macOS: Fix KeePassXC blocking clean shutdown [keepassxreboot#6002]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested on Windows
Type of change