Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menubar click-to-move window with Qt 5.15 #5971

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Fix menubar click-to-move window with Qt 5.15 #5971

merged 1 commit into from
Jan 20, 2021

Conversation

JCallicoat
Copy link

Change logic in click handler in eventFilter so that startSystemMove() is only called when there is no menubar action under the mouse cursor (i.e., when a blank area of the menubar is clicked).

Fixes #5925

Testing strategy

Tested on Arch Linux with Qt 5.15.2

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

Please rebase onto release/2.6.4

@JCallicoat JCallicoat changed the base branch from develop to release/2.6.4 January 20, 2021 06:27
@JCallicoat JCallicoat changed the base branch from release/2.6.4 to develop January 20, 2021 06:28
@JCallicoat JCallicoat changed the base branch from develop to release/2.6.4 January 20, 2021 06:56
Change logic in click handler in eventFilter so that
startSystemMove() is only called when there is no menubar
action under the mouse cursor (i.e., when a blank area
of the menubar is clicked).

Fixes #5925
@droidmonkey droidmonkey merged commit 0d3d5db into keepassxreboot:release/2.6.4 Jan 20, 2021
@droidmonkey droidmonkey added this to the v2.6.4 milestone Jan 20, 2021
phoerious added a commit that referenced this pull request Jan 31, 2021
Added

- Automatically adapt to light/dark system theme changes (Windows/macOS only) [#6034]

Changed

- Show window title as tooltip on system tray [#5948]
- Compress Snap release as LZO for faster initial startup [#5877]
- Password generator: Set maximum selectable password length to 999 [#5937]

Fixed

- Fix crash on app close when using SSH agent [#5935]
- Fix KDF selection showing wrong item when using Argon2id [#5923]
- Automatically close About dialog on database lock if it is still open [#5947]
- Linux: Fix automatic launch at system startup with AppImages [#5901]
- Linux: Fix click-to-move on empty area activating when using menus [#5971]
- Linux: Try multiple times to show tray icon if tray is not ready yet [#5948]
- macOS: Fix KeePassXC blocking clean shutdown [#6002]
aswild added a commit to aswild/keepassxc that referenced this pull request Feb 5, 2021
Release 2.6.4

Added

- Automatically adapt to light/dark system theme changes (Windows/macOS only) [keepassxreboot#6034]

Changed

- Show window title as tooltip on system tray [keepassxreboot#5948]
- Compress Snap release as LZO for faster initial startup [keepassxreboot#5877]
- Password generator: Set maximum selectable password length to 999 [keepassxreboot#5937]

Fixed

- Fix crash on app close when using SSH agent [keepassxreboot#5935]
- Fix KDF selection showing wrong item when using Argon2id [keepassxreboot#5923]
- Automatically close About dialog on database lock if it is still open [keepassxreboot#5947]
- Linux: Fix automatic launch at system startup with AppImages [keepassxreboot#5901]
- Linux: Fix click-to-move on empty area activating when using menus [keepassxreboot#5971]
- Linux: Try multiple times to show tray icon if tray is not ready yet [keepassxreboot#5948]
- macOS: Fix KeePassXC blocking clean shutdown [keepassxreboot#6002]
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bugfix Pull request that fixes a bug user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long mouse click on menu bar text items closes menu (maps to move window?)
3 participants