Correct issues with system tray icon #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
force-pushed
the
hotfix/tray-icon
branch
from
774f726 to
d8aaa08
Compare
* Close #5780 - Show window title as system tray icon tooltip * Fix #5943 - Try to show system tray icon up to 5 times, waiting 5 seconds between attempts, if the system tray is not available. This works around observed startup issues on Linux. * Change function of "isTrayIconEnabled()" to return true if the tray icon is created and visible. This may correct some long standing bugs with the window hiding forever unexpectedly.
droidmonkey
force-pushed
the
hotfix/tray-icon
branch
from
d8aaa08 to
7a94aa5
Compare
This was
linked to
issues
Jan 27, 2021
phoerious
reviewed
Jan 27, 2021
|
|
||
| m_trayIcon->setToolTip(windowTitle().replace("[*]", isWindowModified() ? "*" : "")); |
There was a problem hiding this comment.
Can we somehow construct the tooltip from the original raw title + an asterisk? Updating the existing title will replace any asterisks appearing in the database name. We should never read anything back from the UI.
There was a problem hiding this comment.
That is the explicit placeholder for the modified indicator. It's a stupid qt convention and they keep the placeholder intact for some reason.
There was a problem hiding this comment.
Hmm. I really don't like it, but so be it.
|
|
||
| if (!isTrayIconEnabled() || !QSystemTrayIcon::isSystemTrayAvailable()) { | ||
| // Try to show tray icon after 5 seconds, try 5 times | ||
| // This can happen if KeePassXC starts before the system tray is available |
There was a problem hiding this comment.
I wonder if there are DBus signals we can listen for.
There was a problem hiding this comment.
That is Qt's job which it is failing at doing (that's actually their bug as reported). This works and isn't too bothersome.
There was a problem hiding this comment.
It's definitely Qt's job to do it right, but we might find a more elegant workaround in the future perhaps.
There was a problem hiding this comment.
I'd agree to that :-)
phoerious
approved these changes
Jan 27, 2021
phoerious
added a commit
that referenced
this pull request
Jan 31, 2021
Added - Automatically adapt to light/dark system theme changes (Windows/macOS only) [#6034] Changed - Show window title as tooltip on system tray [#5948] - Compress Snap release as LZO for faster initial startup [#5877] - Password generator: Set maximum selectable password length to 999 [#5937] Fixed - Fix crash on app close when using SSH agent [#5935] - Fix KDF selection showing wrong item when using Argon2id [#5923] - Automatically close About dialog on database lock if it is still open [#5947] - Linux: Fix automatic launch at system startup with AppImages [#5901] - Linux: Fix click-to-move on empty area activating when using menus [#5971] - Linux: Try multiple times to show tray icon if tray is not ready yet [#5948] - macOS: Fix KeePassXC blocking clean shutdown [#6002]
aswild
added a commit
to aswild/keepassxc
that referenced
this pull request
Feb 5, 2021
Release 2.6.4 Added - Automatically adapt to light/dark system theme changes (Windows/macOS only) [keepassxreboot#6034] Changed - Show window title as tooltip on system tray [keepassxreboot#5948] - Compress Snap release as LZO for faster initial startup [keepassxreboot#5877] - Password generator: Set maximum selectable password length to 999 [keepassxreboot#5937] Fixed - Fix crash on app close when using SSH agent [keepassxreboot#5935] - Fix KDF selection showing wrong item when using Argon2id [keepassxreboot#5923] - Automatically close About dialog on database lock if it is still open [keepassxreboot#5947] - Linux: Fix automatic launch at system startup with AppImages [keepassxreboot#5901] - Linux: Fix click-to-move on empty area activating when using menus [keepassxreboot#5971] - Linux: Try multiple times to show tray icon if tray is not ready yet [keepassxreboot#5948] - macOS: Fix KeePassXC blocking clean shutdown [keepassxreboot#6002]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Testing strategy
Tested on Windows and XFCE
Type of change