-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-669] Facebook Conversions API Feature Flag #1766
Conversation
Codecov Report
@@ Coverage Diff @@
## circleci/pipeline-queue #1766 +/- ##
========================================================
Coverage 89.05% 89.05%
========================================================
Files 881 881
Lines 80562 80586 +24
Branches 21134 21148 +14
========================================================
+ Hits 71744 71766 +22
- Misses 8062 8063 +1
- Partials 756 757 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just correct that one test.
@@ -53,6 +54,7 @@ final class OptimizelyFlagToolsViewModelTests: TestCase { | |||
OptimizelyFeature.rewardLocalPickupEnabled.rawValue: false, | |||
OptimizelyFeature.paymentSheetEnabled.rawValue: false, | |||
OptimizelyFeature.settingsPaymentSheetEnabled.rawValue: false, | |||
OptimizelyFeature.facebookConversionsAPI.rawValue: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be false
* [WEB-861] Consent Management feature flag (#1764) * Add new Consent Management Dialog feature flag * Add new Consent Management Dialog feature flag * remove failing view controller test assertion * formatting * Adding a small commit so tests pass on CI. Didn't realize that if we removed the feature from the mock client, the recording would would still have it in the snapshot and our old snapshot wouldn't have been updated yet. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com> * [WEB-696] FacebookResetPassword Improvements (#1765) * remove ResetYourFacebookPasswordViewController snapshots * rename viewmodel and viewcontroller * viewmodel form logic suggestions * update viewmodel tests * ensure the scrollview is not hidden by the keyboard * set returnKeyType to go and make api call on tap * update accessibility on set your password view controller * updated accessibility for facebookresetpasswordviewcontroller. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com> * [WEB-669] Facebook Conversions API Feature Flag (#1766) * add facebook conversions api feature flag * add facebook conversions api feature flag * fix test * [WEB-862] AppTrackingTransparency Authorization (#1772) * set NSUserTrackingUsageDescription in plist * request ATTrackingAuthorization on app applicationdidFinishLaunching * formatting * gate behind consent management dialog feature flag * pr feedback * ATTrackingAuthorizationStatus to its own file * Use `.ksr_debounce` on Signal instead of `asyncAfter` * Handle `restricted` and `@unknown` requestTrackingAuthorization status cases * Improve unit test * use ksr_delay insted of ksr_debounce Co-authored-by: Mubarak Sadoon <msadoon@gmail.com>
📲 What
This PR makes the necessary code changes to add a new 'Facebook Conversions API' feature flag.
🤔 Why
With iOS 14.5+ Apple requires members to grant permission for apps to track them or access their device’s advertising identifier. This means that facebook app members can choose to "Ask app not to track".
If they do this, the facebook pixel that KS uses won't send or receive tracking data. Instead, we'll need to use their Conversions API to track and send events ourselves.
More details around this initiative can be found here
🛠 How
Boilerplate code that adds a new case to the
OptimizelyFeature
enum and then a helper function that checks user defaults before returning the value from theOptimizely
SDK. Finally a case for the newfacebookConversionsAPI
feature case inOptimizelyFeatureFlagTools
👀 See
You can view the new Optimizely flag here
| After 🦋 |
| |
❗️Important Notes❗️
circleci/pipeline-queue
branch off ofmain