[WEB-862] AppTrackingTransparency Authorization #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## circleci/pipeline-queue #1772 +/- ##
===========================================================
- Coverage 85.25% 85.24% -0.02%
===========================================================
Files 1276 1276
Lines 116652 116682 +30
Branches 30760 30779 +19
===========================================================
+ Hits 99451 99464 +13
- Misses 16128 16144 +16
- Partials 1073 1074 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
scottkicks
commented
Jan 19, 2023
scottkicks
commented
Jan 19, 2023
msadoon
suggested changes
Jan 19, 2023
* ATTrackingAuthorizationStatus to its own file * Use `.ksr_debounce` on Signal instead of `asyncAfter` * Handle `restricted` and `@unknown` requestTrackingAuthorization status cases * Improve unit test
msadoon
approved these changes
Jan 19, 2023
|
@msadoon good call out. thanks for the insight. I'll go with the more consistent approach of |
scottkicks
added a commit
that referenced
this pull request
Jan 24, 2023
* [WEB-861] Consent Management feature flag (#1764) * Add new Consent Management Dialog feature flag * Add new Consent Management Dialog feature flag * remove failing view controller test assertion * formatting * Adding a small commit so tests pass on CI. Didn't realize that if we removed the feature from the mock client, the recording would would still have it in the snapshot and our old snapshot wouldn't have been updated yet. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com> * [WEB-696] FacebookResetPassword Improvements (#1765) * remove ResetYourFacebookPasswordViewController snapshots * rename viewmodel and viewcontroller * viewmodel form logic suggestions * update viewmodel tests * ensure the scrollview is not hidden by the keyboard * set returnKeyType to go and make api call on tap * update accessibility on set your password view controller * updated accessibility for facebookresetpasswordviewcontroller. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com> * [WEB-669] Facebook Conversions API Feature Flag (#1766) * add facebook conversions api feature flag * add facebook conversions api feature flag * fix test * [WEB-862] AppTrackingTransparency Authorization (#1772) * set NSUserTrackingUsageDescription in plist * request ATTrackingAuthorization on app applicationdidFinishLaunching * formatting * gate behind consent management dialog feature flag * pr feedback * ATTrackingAuthorizationStatus to its own file * Use `.ksr_debounce` on Signal instead of `asyncAfter` * Handle `restricted` and `@unknown` requestTrackingAuthorization status cases * Improve unit test * use ksr_delay insted of ksr_debounce Co-authored-by: Mubarak Sadoon <msadoon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Presents Apple's AppTransparencyFramework dialog on app didFinishLaunching.
🤔 Why
With iOS 14.5+ you need to receive the user’s permission through the AppTrackingTransparency framework in order to track them or access their device’s advertising identifier.
We need to meet this requirement in order to ethically track facebook ads related data.
context around our consent management initiative
context around our facebook conversions api initiative that will be gates by this authorization status
🛠 How
NSUserTrackingUsageDescriptionin the info.plistdidFinishLaunchingWithOptionsuse the AppTrackingTransparency Framework to request authorizationATTrackingAuthorizationStatusenum to be used by whomever consumes the Signal.Apple only allows us to request this dialog once per fresh install until someone decides to allow or deny permission.
👀 See
Trello, screenshots, external resources?
⏰ TODO