[WEB-861] Consent Management feature flag #1764
Conversation
scottkicks
changed the title
|
@msadoon I'll just need some help with the snapshot tests |
There was a problem hiding this comment.
Hey Scott,
Before we start down this path, I just want to understand the scope of the feature and its' necessity. I read your consent management document and left some comments. Can we talk about those first before proceeding?
|
@msadoon definitely. i'll slack you to setup a time to discuss. |
There was a problem hiding this comment.
A few changes, nothing major.
One thing, instead of merging to main...because our CI pipelines are broken, let's merge to a new branch called circleci/pipeline-queue.
This new branch can be created off main and pushed up and going forward let's merge everything into it until we get our cirlce ci pipelines back.
Small thing: Any Snapshot tests that get need to be re-recorded can be skipped on your M1. Just add notes to this PR please, so we can keep track of which screens need re-records. At least that way we merge PR's that don't have any failing tests.
...es/OptimizelyFeatureFlagTools/Controller/OptimizelyFeatureFlagToolsViewControllerTests.swift
Outdated
Show resolved
Hide resolved
Didn't realize that if we removed the feature from the mock client, the recording would would still have it in the snapshot and our old snapshot wouldn't have been updated yet.
Codecov Report
@@ Coverage Diff @@
## circleci/pipeline-queue #1764 +/- ##
===========================================================
- Coverage 85.29% 85.25% -0.05%
===========================================================
Files 1276 1276
Lines 116541 116550 +9
Branches 30722 30734 +12
===========================================================
- Hits 99408 99365 -43
- Misses 16066 16117 +51
- Partials 1067 1068 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* [WEB-861] Consent Management feature flag (#1764) * Add new Consent Management Dialog feature flag * Add new Consent Management Dialog feature flag * remove failing view controller test assertion * formatting * Adding a small commit so tests pass on CI. Didn't realize that if we removed the feature from the mock client, the recording would would still have it in the snapshot and our old snapshot wouldn't have been updated yet. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com> * [WEB-696] FacebookResetPassword Improvements (#1765) * remove ResetYourFacebookPasswordViewController snapshots * rename viewmodel and viewcontroller * viewmodel form logic suggestions * update viewmodel tests * ensure the scrollview is not hidden by the keyboard * set returnKeyType to go and make api call on tap * update accessibility on set your password view controller * updated accessibility for facebookresetpasswordviewcontroller. * formatting Co-authored-by: Mubarak Sadoon <msadoon@gmail.com> * [WEB-669] Facebook Conversions API Feature Flag (#1766) * add facebook conversions api feature flag * add facebook conversions api feature flag * fix test * [WEB-862] AppTrackingTransparency Authorization (#1772) * set NSUserTrackingUsageDescription in plist * request ATTrackingAuthorization on app applicationdidFinishLaunching * formatting * gate behind consent management dialog feature flag * pr feedback * ATTrackingAuthorizationStatus to its own file * Use `.ksr_debounce` on Signal instead of `asyncAfter` * Handle `restricted` and `@unknown` requestTrackingAuthorization status cases * Improve unit test * use ksr_delay insted of ksr_debounce Co-authored-by: Mubarak Sadoon <msadoon@gmail.com>
📲 What
This PR makes the necessary code changes to add a new 'Consent Management' feature flag.
🤔 Why
With iOS 14.5+, iPadOS 14.5+, we need to receive member's permission through the Apple's AppTrackingTransparency framework in order to track them or access their device’s advertising identifier.
This flag will gate the work that will be done to implement this.
More details around this initiative can be found here
🛠 How
Boilerplate code that adds a new case to the
OptimizelyFeatureenum and then a helper function that checks user defaults before returning the value from theOptimizelySDK. Finally a case for the newconsentManagementEnabledfeature case inOptimizelyFeatureFlagTools👀 See
Optimizely Feature Flag menu in our Beta Tools
| After 🦋 |
|
|
Important Notes
circleci/pipeline-queuebranch off ofmainOptimizelyFeatureFlagToolsViewControllerTestsonce the snapshot fixes pr goes out