Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bugs from switching to Debian image #579

Merged
merged 3 commits into from
Feb 18, 2021
Merged

🐛 Fix bugs from switching to Debian image #579

merged 3 commits into from
Feb 18, 2021

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented Feb 17, 2021

Tested locally with docker-compose on the ingest-app branch. Ran the start ingest run mutation and the worker looks like it picks up the job and executes successfully.

@znatty22 znatty22 added the bug Something isn't working label Feb 17, 2021
@znatty22 znatty22 self-assigned this Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #579 (874ff6b) into master (fa5896a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          92       92           
  Lines        4025     4025           
=======================================
  Hits         3761     3761           
  Misses        264      264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5896a...874ff6b. Read the comment docs.

@znatty22 znatty22 marked this pull request as ready for review February 17, 2021 20:08
Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥭

@znatty22 znatty22 force-pushed the ash-to-bash branch 2 times, most recently from 4d8db8c to a0fffd0 Compare February 18, 2021 13:44
Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@znatty22 znatty22 merged commit 40cf58c into master Feb 18, 2021
@znatty22 znatty22 deleted the ash-to-bash branch February 18, 2021 14:47
dankolbman added a commit that referenced this pull request Feb 24, 2021
## Release 1.15.0

### Summary

- Emojis: ✨ x1, 🔧 x2, 🐛 x3, ⬆️ x2, 🐳 x1, 💄 x1
- Categories: Additions x1, Other Changes x3, Fixes x3, Ops x3

### New features and changes

- [#581](#581) - ✨ Add investigator name to study - [7c147b2](7c147b2) by [dankolbman](https://github.com/dankolbman)
- [#580](#580) - 🔧 Add flag to enabled/disable DR bucket creation - [428020b](428020b) by [dankolbman](https://github.com/dankolbman)
- [#573](#573) - 🔧 Add settings to status schema - [7c03def](7c03def) by [dankolbman](https://github.com/dankolbman)
- [#579](#579) - 🐛 Fix bugs from switching to Debian image - [40cf58c](40cf58c) by [znatty22](https://github.com/znatty22)
- [#578](#578) - ⬆️ Bump boto3 and requests - [fa5896a](fa5896a) by [znatty22](https://github.com/znatty22)
- [#577](#577) - 🐳 Switch to python:3.8-slim-buster docker img - [3ca47fd](3ca47fd) by [znatty22](https://github.com/znatty22)
- [#567](#567) - 💄 Clean up release messages - [843f0ba](843f0ba) by [dankolbman](https://github.com/dankolbman)
- [#572](#572) - ⬆️ Bump cryptography from 3.2 to 3.3.2 - [e046430](e046430) by [dependabot[bot]](https://github.com/apps/dependabot)
- [#566](#566) - 🐛 Only verify release id if its in the response - [d27077d](d27077d) by [dankolbman](https://github.com/dankolbman)
- [#564](#564) - 🐛 Add safeguards for trace sampler - [32e7f2e](32e7f2e) by [dankolbman](https://github.com/dankolbman)
@dankolbman dankolbman mentioned this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants