Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ReVIEW::Configure.create #1549

Merged
merged 1 commit into from
Aug 18, 2020
Merged

add ReVIEW::Configure.create #1549

merged 1 commit into from
Aug 18, 2020

Conversation

takahashim
Copy link
Collaborator

It's general purpose constructor of ReVIEW::Configure.

@kmuto
Copy link
Owner

kmuto commented Aug 18, 2020

なるほど、これはすっきりしますね。

@takahashim
Copy link
Collaborator Author

*Maker はだいたいこれで整理できたはずです。

あと、::EPUBMaker::Producer の @config はこれらともまた違う変わった初期化をしているので、これもどこかで何とかしたいところです…。

@takahashim takahashim merged commit c43ffd1 into master Aug 18, 2020
@takahashim takahashim deleted the add-configure-create branch August 18, 2020 10:21
kmuto added a commit that referenced this pull request Sep 28, 2020
@kmuto
#1384,#1393,#1497,#1543,#1544,#1545,#1548,#1549,#1550,#1551,#1552,#1558,
7a65c7f 
#1559,#1560,#1562,#1563,#1564,#1569,#1572,#1573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahashim @kmuto