Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use IndexBuilder instead of *Index.parse() #1384

Merged
merged 8 commits into from
Aug 25, 2020
Merged

use IndexBuilder instead of *Index.parse() #1384

merged 8 commits into from
Aug 25, 2020

Conversation

takahashim
Copy link
Collaborator

ReVIEW::Book::Index.parseを全面的に置き換えるものです。
インデックス専用のbuilderを作って何とかする作戦です。

@takahashim
Copy link
Collaborator Author

先に Index::Item を整理した方が良いかも。

@kmuto
Copy link
Owner

kmuto commented Aug 25, 2019

方針よさそうなので進めていただくことに

@kmuto kmuto mentioned this pull request Sep 16, 2019
Closed
@kmuto kmuto mentioned this pull request Oct 29, 2019
Closed
28 tasks
@kmuto kmuto mentioned this pull request Jun 12, 2020
Closed
@takahashim takahashim mentioned this pull request Jun 29, 2020
Closed
@takahashim takahashim force-pushed the make-indexes branch 3 times, most recently from 6e4cca6 to b90cdec Compare August 19, 2020 15:41
@takahashim takahashim changed the title WIP: fix indexer fix indexer Aug 19, 2020
@takahashim takahashim marked this pull request as ready for review August 19, 2020 15:59
@takahashim
Copy link
Collaborator Author

とりあえず動くようになった（けど遅そう）

@takahashim
Copy link
Collaborator Author

と思ったけどまだダメそう…

@takahashim
Copy link
Collaborator Author

これでだいたい直ったはず

@kmuto
Copy link
Owner

kmuto commented Aug 23, 2020

IndexBuilder#bind で @output = StringIO.new を（IndexBuilderでは使わないにしても）提供したほうがよさそうです。
既存のreview-ext.rbで既定用にBuilderクラスに追加した命令内でputsを使っていると、Builder#putsの@output.putsがIndexBuilderにおいてnil.putsとなってしまって、わりと影響大きい…。

@takahashim
Copy link
Collaborator Author

なるほど、足しておきます

@takahashim takahashim mentioned this pull request Aug 23, 2020
Merged
@takahashim takahashim changed the title fix indexer use IndexBuilder instead of *Index.parse() Aug 23, 2020
@kmuto
Copy link
Owner

kmuto commented Aug 24, 2020

ありがとうございます、私の抱えるプロジェクト範囲だと特に問題はないようです。とりあえず遅くなったというのも感じないような。

@takahashim
Copy link
Collaborator Author

遅かったのは同じファイルに対してIndexBuilderが何度も走っていたからでした。ここは整理したので、現状はそんなに遅くなっていない（といいなあ）、というところです

@takahashim
Copy link
Collaborator Author

だいたいこれで良さそうなので、あとでマージしてみます

@takahashim takahashim merged commit 0b94d58 into master Aug 25, 2020
@takahashim takahashim deleted the make-indexes branch August 25, 2020 17:29
kmuto added a commit that referenced this pull request Sep 28, 2020
@kmuto
#1384,#1393,#1497,#1543,#1544,#1545,#1548,#1549,#1550,#1551,#1552,#1558,
7a65c7f 
#1559,#1560,#1562,#1563,#1564,#1569,#1572,#1573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahashim @kmuto