-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger reconciler tests for ConsumerGroup scaling #1756
Trigger reconciler tests for ConsumerGroup scaling #1756
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1756 +/- ##
============================================
+ Coverage 66.21% 67.67% +1.45%
- Complexity 614 617 +3
============================================
Files 129 129
Lines 5293 5330 +37
Branches 177 177
============================================
+ Hits 3505 3607 +102
+ Misses 1503 1438 -65
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review of this PR, looks good overall.
Signed-off-by: aavarghese <avarghese@us.ibm.com>
Signed-off-by: aavarghese <avarghese@us.ibm.com>
3365c5e
to
f16b88f
Compare
Signed-off-by: aavarghese <avarghese@us.ibm.com>
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aavarghese, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: aavarghese avarghese@us.ibm.com
Part of #1537
/cc @pierDipi
Proposed Changes
Release Note
Docs