-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update report dependencies endpoint to group by name only #557
Comments
cc @ibolton336 |
I don't think so... At the very least, they will not have a use on the dependencies table. |
jortel
added a commit
that referenced
this issue
Nov 15, 2023
Update /analyses/report/dependencies to group by (provider, name) instead of (name, version, sha). Currently, provider is always "". Removes DepReport fields: - version - sha Also fixes DepAppReport.SHA JSON field name. fixes: #557 --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
sjd78
added a commit
to konveyor/tackle2-ui
that referenced
this issue
Nov 15, 2023
…etails (#1536) Resolves: #1338 Resolves: https://issues.redhat.com/browse/MTA-1585 Depends on hub change konveyor/tackle2-hub#557 / konveyor/tackle2-hub#558. Summary of changes: - The dependency table will show a single row for every named dependency. - Multiple versions will be aggregated as a single row. - Details about multiple versions will be available in the details drawer. - The details view application table will show the application + version, allowing for all versions used to be listed. --------- Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
ibolton336
added a commit
to konveyor/tackle2-ui
that referenced
this issue
Nov 15, 2023
Resolves: #1340 On the Dependencies page, detail drawer, applications table: render the version text as a link to the maven central repository. The link uses the dependency's sha as the key in the maven central search. Add component `ExternalLink` to standardize rendering links outside of the app opening in a new tab. Note: The resolution to #1338 will require a change to the application table's query filter and response object. This will be done in PR #1536. See konveyor/tackle2-hub#557 for the response object change. Screenshot:  --------- Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For UI changes konveyor/tackle2-ui#1338 and konveyor/tackle2-ui#1340, the dependency table needs to display dependencies grouped by name only. It currently displays rows based on name and sha.
Endpoint
/analyses/report/dependencies
is what is currently being used. It returns struct:Please adjust the response to group dependencies by name only. The
SHA
andVersion
fields are no longer needed. TheApplications
count andLabels
summary fields should also be adjusted.Endpoint
/analyses/reports/dependencies/applications
is used by the application table on a dependency's details view. This endpoint works as needed, but the response object has the dependency's sha named "rule":Please rename the SHA field's json name to "sha".
The text was updated successfully, but these errors were encountered: