Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove columns from the main table in Dependencies view #1338

Closed
rromannissen opened this issue Sep 8, 2023 · 1 comment · Fixed by #1536
Closed

Remove columns from the main table in Dependencies view #1338

rromannissen opened this issue Sep 8, 2023 · 1 comment · Fixed by #1536
Assignees
@sjd78
Labels
priority/release-blocker Must be staffed and worked in time for the next release.
Milestone
v0.3.0

Comments

@rromannissen
Copy link

Environment

  • Fedora 36
  • minikube v1.31.2 (--driver=kvm2 --memory=10g --cpus=3)
  • Konveyor 0.3 alpha-2 with additional images:
    • ui_image_fqin: quay.io/ibolton/tackle2-ui:demo
    • hub_image_fqin: quay.io/jortel/tackle2-hub:demo
    • analyzer_fqin: quay.io/jortel/tackle2-addon-analyzer:demo
  • tackle-testapp application
  • Analysis configuration:
    • Source + Dependencies
    • cloud-readiness, linux
    • Application and internal dependencies only
    • No custom rules
    • No additional advanced options

Description

The main table in the Dependencies view contains the Version and SHA columns. Those columns don't belong at dependency level and should be removed, since each dependency can have multiple versions and each version has its own SHA.

How to reproduce

Click on Dependencies on the left menu.

Expected result

Screenshot from 2023-09-08 13-28-51

Actual result

Screenshot from 2023-09-08 13-38-31
@rromannissen
Copy link
Author

@dymurray Reproduced in 0.3-alpha5

@dymurray dymurray added the priority/release-blocker Must be staffed and worked in time for the next release. label Nov 13, 2023
@dymurray dymurray added this to the v0.3.0 milestone Nov 13, 2023
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Nov 13, 2023
@sjd78
Remove Version and SHA columns from main dependencies tables
947ca4e 
Resolves: konveyor#1338

The version and sha filters, column headers and columns have been
removed.  Those two fields are not relevant in this table.  The
table does not need those details.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 mentioned this issue Nov 13, 2023
Merged
@sjd78 sjd78 self-assigned this Nov 13, 2023
This was referenced Nov 14, 2023
Closed
Merged
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Nov 15, 2023
@sjd78
Remove Version and SHA columns from main dependencies tables
9f9652e 
Resolves: konveyor#1338

The version and sha filters, column headers and columns have been
removed.  Those two fields are not relevant in this table.  The
table does not need those details.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit that referenced this issue Nov 15, 2023
@sjd78
✨ Regroup the dependencies table on name only, version/sha shown in d…
06d6551 
…etails (#1536)

Resolves: #1338
Resolves: https://issues.redhat.com/browse/MTA-1585

Depends on hub change konveyor/tackle2-hub#557
/ konveyor/tackle2-hub#558.

Summary of changes:
  - The dependency table will show a single row for every named
    dependency.
  - Multiple versions will be aggregated as a single row.
  - Details about multiple versions will be available in the details
    drawer.
  - The details view application table will show the application +
    version, allowing for all versions used to be listed.

---------

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
ibolton336 added a commit that referenced this issue Nov 15, 2023
@sjd78 @ibolton336
🐛 Render dependency versions as links (#1540)
2500fbc 
Resolves: #1340

On the Dependencies page, detail drawer, applications table: render the
version text as a link to the maven central repository. The link uses
the dependency's sha as the key in the maven central search.

Add component `ExternalLink` to standardize rendering links outside of
the app opening in a new tab.

Note: The resolution to #1338 will require a change to the application
table's query filter and response object. This will be done in PR #1536.
See konveyor/tackle2-hub#557 for the response
object change.

Screenshot:

![image](https://github.com/konveyor/tackle2-ui/assets/3985964/50f0c144-b4fe-4ba2-a625-3c8e6ae3be6c)

---------

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
priority/release-blocker Must be staffed and worked in time for the next release.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

✨ Regroup the dependencies table on name only, version/sha shown in details sjd78/tackle2-ui
3 participants
@sjd78 @rromannissen @dymurray