🐛 Render dependency versions as links #1540
Conversation
sjd78
force-pushed
the
mvn_link_dependencies
branch
2 times, most recently
from
9d9245e
to
17f1430
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
+ Coverage 40.46% 40.51% +0.05%
==========================================
Files 145 145
Lines 4636 4640 +4
Branches 1088 1089 +1
==========================================
+ Hits 1876 1880 +4
Misses 2746 2746
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| provider, | ||
| name, | ||
| version, | ||
| rule: sha, // TODO: rename to 'sha' with https://github.com/konveyor/tackle2-hub/issues/557 |
There was a problem hiding this comment.
LGTM - wondering if we should hold off for the hub PR to merge?
There was a problem hiding this comment.
Option 1 - hold off and update this PR at the same time
Option 2 - merge this PR and fix the payload with #1536
I'm leaning towards option 2, but it is not a strong preference.
There was a problem hiding this comment.
Merging and circling back sounds ok to me.
|
Both have been merged. No additional blockers for merging. |
sjd78
force-pushed
the
mvn_link_dependencies
branch
from
b55b670
to
1eb6e56
Compare
Resolves: konveyor#1340 On the Dependencies page, detail drawer, applications table: render the version text as a link to the maven central repository. The link uses the dependency's sha as the key in the maven central search. Add component `ExternalLink` to standardize rendering links outside of the app opening in a new tab. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
mvn_link_dependencies
branch
from
1eb6e56
to
4672df5
Compare
Resolves: #1340
On the Dependencies page, detail drawer, applications table: render the version text as a link to the maven central repository. The link uses the dependency's sha as the key in the maven central search.
Add component
ExternalLinkto standardize rendering links outside of the app opening in a new tab.Note: The resolution to #1338 will require a change to the application table's query filter and response object. This will be done in PR #1536. See konveyor/tackle2-hub#557 for the response object change.
Screenshot:
