forked from jupyter-lsp/jupyterlab-lsp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage #7
Open
krassowski
wants to merge
48
commits into
main
Choose a base branch
from
fix-coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix coverage #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Invalidates On Focus Loss`, - `Hover works in foreign code (javascript)` - `Mid Token Completions Do Not Overwrite`
If it helps, it might be indicative of performance problem
Final pass before 5.0 release
Use `sys.executable` in stdio tests
Use shutil.which result to run npm
fix: handle CORS OPTIONS request
Fix typo in setting title
* Resolve traitlets type warnings, lint, remove `six` * Explicit default value * Use `traitlets.Any` because this is really a pathlib Path but we would need to pull https://github.com/Zsailer/traitlets_paths which was not updated in 5 years so it may not work
…1007) * Fix cell magic is run in a different scope * Apply lint * Update CHANGELOG * Fix regex * Resolve traitlets type warnings, lint, remove `six` --------- Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
* Resolve traitlets type warnings, lint, remove `six` * Workaround issue with markdown lost on edit
* Switch to build-in dedupe * Remove lerna bootstrap as it is not supported for yarn 2+
* Bump axios from 1.2.1 to 1.6.2 Bumps [axios](https://github.com/axios/axios) from 1.2.1 to 1.6.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.2.1...v1.6.2) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Fix lcokfile --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
* Bump @babel/traverse from 7.22.5 to 7.23.4 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.23.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.4/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Fix lockfile --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
* Address jest deprecation warning * Only pre-filter LSP completions, not the kernel completions * Apply suggestions from code review Make newly added `resolveQuery` protected
The issue was that: - (a) heuristic did not account for eliding - (b) styles limiting the width were not applied when the widest item size was calculated after temporarily re-parenting to `<body>` - (c) there was no limit on ellipsis width (now its 50% of label) - (d) the label size limit maybe was too low, it got increased by 50px
* Respect user-set `priority` over `priority` set by `overrides.json` * Add a test for merging user settings with defaults
…ed (jupyter-lsp#1036) * Re-register native completion providers when LSP completion is disabled * Disable, not disabled * Update changelog, bump versions * Fix test: `test` completion gets suggested from context even when lsp is off (with type "Statement" in CM6)
* Add auth decorators, add traversal guard * Fix mocks resolving most test failures; `test_listeners` still fails not sure how to fix it * Address review comments * add tests for (un)authn'd REST and WebSocket handlers * Restore old import for 1.x compat, remove a log * handle advertised jupyter-server 1.x version * Lint (isort any mypy) * More tests for paths --------- Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com>
…pyter-lsp#1039) * Update `CHANGELOG.md` with additional info on jupyter-lsp release * Clarity and grammar
* Fix completions when `type` is not defined * Fix linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
User-facing changes
Backwards-incompatible changes
Chores