-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clientset for MPIJob, PytorchJob, MXJob, and XGBoostJob #1610
Conversation
baac7cb
to
230baee
Compare
Pull Request Test Coverage Report for Build 2482116121
💛 - Coveralls |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@kubeflow/wg-training-leads Please take a look. |
/cc @zw0610 |
I have grouped Go dependencies. |
I have updated links to API documentation in README.md. |
Thank you very much for your contribution! After the test passed, could you squash multiple commits into one? |
Thanks for your comment! @zw0610 |
b2bf97a
to
766813b
Compare
@zw0610 I have squashed all commits and passed all tests. |
/assign @zw0610 |
@zw0610 @gaocegege Can you please review this so that we can get it in this release? |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a breaking change for developers since the API packages are changed from gtihub.com/kubeflow/training-operator/pkg/apis/tensorflow/v1
to gtihub.com/kubeflow/training-operator/pkg/apis/kubeflow.org/v1
We should notice users in some degree
The PR itself LGTM
Thanks for your contribution! 🎉 👍
@zw0610 @gaocegege Thanks for your review of this large PR!
I agree with you. |
this fix is long-overdue. Thank you again for this tremendous work. |
@johnugeorge Could we merge it? |
Thanks everyone |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
As discussed in here, I moved Kubernetes Custom Resource API codes to the
pkg/apis/kubeflow.org/v1
directory to generate Go clientset for MPIJob, PytorchJob, MXJob, and XGBoostJob.So, I made the following changes:
pkg/apis/[mpi|mxnet|pytorch|tensorflow|xgboost]/[v1|validation]/*.go
topkg/apis/kubeflow.org/v1/*.go
.defaulting
andvalidation tests
.MPIJobDefaultPortName
) to variable names that conflict between all frameworks.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1499, #1501, #1586, #1592
Checklist: