Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pytorch mpi mxnet xgboost clientset and update doc #1611

Closed
wants to merge 2 commits into from

Conversation

41tair
Copy link

@41tair 41tair commented Jun 11, 2022

add defaults.go and update codegen shell

regenerate client according to the new api structure

regenerate with new script args

add validation and test

Bump protobuf from 3.8.0 to 3.15.0 in /py/kubeflow/tf_operator

Bumps protobuf from 3.8.0 to 3.15.0.


updated-dependencies:

  • dependency-name: protobuf
    dependency-type: direct:production
    ...

Signed-off-by: dependabot[bot] support@github.com

fix api not fix error

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1586

Checklist:

add defaults.go and update codegen shell

regenerate client according to the new api structure

regenerate with new script args

add validation and test

Bump protobuf from 3.8.0 to 3.15.0 in /py/kubeflow/tf_operator

Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.8.0 to 3.15.0.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.8.0...v3.15.0)

---
updated-dependencies:
- dependency-name: protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

fix api not fix error
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 41tair
To complete the pull request process, please assign zw0610 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zw0610 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@41tair
Copy link
Author

41tair commented Jun 11, 2022

@tenzen-y sorry for the delay of this PR. #1586 auto closed, after i reset code to the master.This PR update apis,docs, controller and generate script in hack

@tenzen-y
Copy link
Member

tenzen-y commented Jun 11, 2022

@tenzen-y sorry for the delay of this PR. #1586 auto closed, after i reset code to the master.This PR update apis,docs, controller and generate script in hack

Since there was no update on PR #1586 yesterday I created a new PR #1610 today...

@41tair
Copy link
Author

41tair commented Jun 11, 2022

@tenzen-y sorry for the delay of this PR. #1586 auto closed, after i reset code to the master.This PR update apis,docs, controller and generate script in hack

Since there was no update on PR #1586 yesterday I created a new PR #1610 today...

My bad,too much work need to do this week.Maybe we can communicate with email next time.U can close it or check the diff between them.😀

@johnugeorge
Copy link
Member

johnugeorge commented Jun 14, 2022

Thanks @41tair. we can close this PR as #1610 is merged

@41tair 41tair closed this Jun 14, 2022
@41tair 41tair deleted the master branch June 14, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants