Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate machine-controller to new addons mechanism #1412

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jul 7, 2021

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1356

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Migrate machine-controller to new addons mechanism

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 7, 2021
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 7, 2021
@kron4eg kron4eg marked this pull request as ready for review July 7, 2021 16:50
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2021
@kron4eg kron4eg requested a review from xmudrii July 7, 2021 16:52
addons/machinecontroller/machine-controller.yaml Outdated Show resolved Hide resolved
pkg/certificate/certificate.go Outdated Show resolved Hide resolved
pkg/templates/machinecontroller/helper.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2021
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2021
@kron4eg kron4eg requested a review from xmudrii July 8, 2021 15:20
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cba833a0c089804e975048128f76c954281f5940

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit d116bb7 into kubermatic:master Jul 8, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jul 8, 2021
@kron4eg kron4eg deleted the mc-addon branch July 8, 2021 22:31
hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 3, 2021
* upstream/master: (75 commits)
  Fix addind second container to machinecontroller webhook deployment (kubermatic#1433)
  Update digitalocean CCM to v0.1.33 (kubermatic#1429)
  Update hetzner CCM manifest to v1.9.1 (kubermatic#1428)
  Improve the v1.3.0-alpha.0 changelog (kubermatic#1425)
  Update CHANGELOG for v1.3.0-alpha.0 (kubermatic#1424)
  Upgrade machinecontroller addon apiextensions to v1 API (kubermatic#1423)
  New drainer (kubermatic#1422)
  Add .clusterNetwork.kubeProxy config example (kubermatic#1421)
  New kube-proxy configuration API (kubermatic#1420)
  Run E2E tests if addons are changed (kubermatic#1417)
  Replace stringData with data in Packet cloud-config Secret (kubermatic#1415)
  Fix kubeone reset error when trying to list Machines (kubermatic#1416)
  Hetzner CSI addon (kubermatic#1418)
  Minor improvements to addons (kubermatic#1414)
  machine-controller: Inject EnvVarBindings only for needed credentials (kubermatic#1413)
  Migrate machine-controller to new addons mechanism (kubermatic#1412)
  Replace the vSphere CCM Go template with an embedded addon (kubermatic#1410)
  Replace the metrics-server CCM Go template with an embedded addon (kubermatic#1411)
  Replace the OpenStack CCM Go template with an embedded addon (kubermatic#1402)
  Migrate WeaveNet to YAML addons (kubermatic#1407)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert machine-controller Go-based template to YAML addon
3 participants