Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade machinecontroller addon apiextensions to v1 API #1423

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jul 16, 2021

What this PR does / why we need it:
In kubernetes 1.22 API apiextensions/v1beta1 will be deleted, so here's upgraded version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade machinecontroller addon apiextensions to v1 API

@kron4eg kron4eg requested a review from xmudrii July 16, 2021 14:51
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 16, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2021
@kron4eg kron4eg marked this pull request as draft July 16, 2021 16:05
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2021
@kron4eg kron4eg force-pushed the mc-apiextensions-v1 branch from 581e5a1 to a347a3f Compare July 16, 2021 16:21
@kron4eg kron4eg marked this pull request as ready for review July 16, 2021 16:23
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2021
@kron4eg kron4eg marked this pull request as draft July 16, 2021 17:27
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2021
@kron4eg kron4eg force-pushed the mc-apiextensions-v1 branch from a347a3f to bca76d6 Compare July 19, 2021 11:04
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg force-pushed the mc-apiextensions-v1 branch from bca76d6 to 57bcdc8 Compare July 19, 2021 14:13
@kron4eg kron4eg marked this pull request as ready for review July 19, 2021 14:14
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ba18cfc949cb4ed371b6590934ca57a51802576

@kubermatic-bot kubermatic-bot merged commit f08d2f8 into kubermatic:master Jul 20, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jul 20, 2021
@kron4eg kron4eg deleted the mc-apiextensions-v1 branch July 20, 2021 10:23
hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 3, 2021
* upstream/master: (75 commits)
  Fix addind second container to machinecontroller webhook deployment (kubermatic#1433)
  Update digitalocean CCM to v0.1.33 (kubermatic#1429)
  Update hetzner CCM manifest to v1.9.1 (kubermatic#1428)
  Improve the v1.3.0-alpha.0 changelog (kubermatic#1425)
  Update CHANGELOG for v1.3.0-alpha.0 (kubermatic#1424)
  Upgrade machinecontroller addon apiextensions to v1 API (kubermatic#1423)
  New drainer (kubermatic#1422)
  Add .clusterNetwork.kubeProxy config example (kubermatic#1421)
  New kube-proxy configuration API (kubermatic#1420)
  Run E2E tests if addons are changed (kubermatic#1417)
  Replace stringData with data in Packet cloud-config Secret (kubermatic#1415)
  Fix kubeone reset error when trying to list Machines (kubermatic#1416)
  Hetzner CSI addon (kubermatic#1418)
  Minor improvements to addons (kubermatic#1414)
  machine-controller: Inject EnvVarBindings only for needed credentials (kubermatic#1413)
  Migrate machine-controller to new addons mechanism (kubermatic#1412)
  Replace the vSphere CCM Go template with an embedded addon (kubermatic#1410)
  Replace the metrics-server CCM Go template with an embedded addon (kubermatic#1411)
  Replace the OpenStack CCM Go template with an embedded addon (kubermatic#1402)
  Migrate WeaveNet to YAML addons (kubermatic#1407)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants