Minor improvements to addons #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
kron4eg
approved these changes
Jul 9, 2021
|
LGTM label has been added. Git tree hash: e76dbc8ad105b86475851c6d70f7badebd8bc9e2
|
hwuethrich
added a commit
to hwuethrich/kubeone
that referenced
this pull request
Aug 3, 2021
* upstream/master: (75 commits) Fix addind second container to machinecontroller webhook deployment (kubermatic#1433) Update digitalocean CCM to v0.1.33 (kubermatic#1429) Update hetzner CCM manifest to v1.9.1 (kubermatic#1428) Improve the v1.3.0-alpha.0 changelog (kubermatic#1425) Update CHANGELOG for v1.3.0-alpha.0 (kubermatic#1424) Upgrade machinecontroller addon apiextensions to v1 API (kubermatic#1423) New drainer (kubermatic#1422) Add .clusterNetwork.kubeProxy config example (kubermatic#1421) New kube-proxy configuration API (kubermatic#1420) Run E2E tests if addons are changed (kubermatic#1417) Replace stringData with data in Packet cloud-config Secret (kubermatic#1415) Fix kubeone reset error when trying to list Machines (kubermatic#1416) Hetzner CSI addon (kubermatic#1418) Minor improvements to addons (kubermatic#1414) machine-controller: Inject EnvVarBindings only for needed credentials (kubermatic#1413) Migrate machine-controller to new addons mechanism (kubermatic#1412) Replace the vSphere CCM Go template with an embedded addon (kubermatic#1410) Replace the metrics-server CCM Go template with an embedded addon (kubermatic#1411) Replace the OpenStack CCM Go template with an embedded addon (kubermatic#1402) Migrate WeaveNet to YAML addons (kubermatic#1407) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces the following changes to addons:
stringDatawithdatain Secretskubectl applyis keeping the manifest used to apply the object in thekubectl.kubernetes.io/last-applied-configurationannotationstringDatais used for creating the Secret, the annotation will contain the plain-text Secret instead of base64 encodedstringData. This will be fixed in a follow-upcaBundle-hashannotation to vSphere and OpenStack CCM addonscloudConfig-hashannotation to vSphere and OpenStack CCM addonsDoes this PR introduce a user-facing change?:
/assign @kron4eg