-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an importable version
cobra.Command
#23
Comments
/good-first-issue |
@justaugustus: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I like it. Take a look at what we did in cosign: https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/version.go The cli calls to the version package lib and spits out a bunch of standard things. https://github.com/sigstore/cosign/blob/main/pkg/version/version.go |
/assign |
Thanks Scott!!! |
thanks scott 🎉 |
I feel like we write a
version
package/version for multiple projects. Could we abstract/de-dupe?Consider writing this as a package in sigs.k8s.io/release-utils that can be an importable
cobra.Command
.See https://github.com/kubernetes/enhancements/tree/master/pkg/kepctl/commands for an example, as well @n3wscott's comments in kubernetes/enhancements#2387 (review) for more background.
Originally posted by @justaugustus in kubernetes-sigs/bom#27 (review)
The text was updated successfully, but these errors were encountered: