Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding importable version cobra command #28

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Adding importable version cobra command #28

merged 1 commit into from
Feb 4, 2022

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Feb 4, 2022

Signed-off-by: Scott Nichols n3wscott@chainguard.dev

What type of PR is this?

/kind feature

What this PR does / why we need it:

Stop duplicating that version logic all over the place :D

Which issue(s) this PR fixes:

fixes #23

Does this PR introduce a user-facing change?

Adding an importable cobra version command.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 4, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2022
@n3wscott n3wscott force-pushed the importable-version branch 2 times, most recently from 12e3b69 to 9b912dd Compare February 4, 2022 01:43
@n3wscott n3wscott changed the title Adding importable version command for cobra Adding importable version cobra command Feb 4, 2022
@n3wscott
Adding importable version command for cobra
de05ea5 
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
@puerco
Copy link
Member

puerco commented Feb 4, 2022

Awesome work, thanks a lot @n3wscott 🚀
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 90cc83d into kubernetes-sigs:main Feb 4, 2022
@cpanato
Copy link
Member

cpanato commented Feb 4, 2022

thanks @n3wscott 🎉

This was referenced Feb 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlydole onlydole Awaiting requested review from onlydole

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an importable version cobra.Command
4 participants
@n3wscott @puerco @k8s-ci-robot @cpanato